Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESPnet2 swbd_sentiment recipe #4134

Merged
merged 8 commits into from
Mar 7, 2022
Merged

ESPnet2 swbd_sentiment recipe #4134

merged 8 commits into from
Mar 7, 2022

Conversation

YushiUeda
Copy link
Contributor

This PR adds ESPnet2 swdb_sentiment recipe.

@sw005320 sw005320 added Recipe SLU Spoken language understanding labels Mar 5, 2022
@sw005320 sw005320 added this to the v.0.10.7 milestone Mar 5, 2022
@sw005320 sw005320 requested a review from ftshijt March 5, 2022 18:55
ftshijt
ftshijt reviewed Mar 6, 2022
View reviewed changes
Copy link
Collaborator

@ftshijt ftshijt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks! A few minor comments as attached

egs2/swbd_sentiment/asr1/conf/decode_asr.yaml Outdated Show resolved Hide resolved
egs2/swbd_sentiment/asr1/conf/tuning/train_asr_conformer_wav2vec2.yaml Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 6, 2022 •
edited

Codecov Report

Merging #4134 (d537330) into master (a04a98c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4134   +/-   ##
=======================================
  Coverage   80.43%   80.43%           
=======================================
  Files         442      442           
  Lines       38557    38557           
=======================================
  Hits        31015    31015           
  Misses       7542     7542
Flag Coverage Δ
test_integration_espnet1 67.13% <ø> (ø)
test_integration_espnet2 51.14% <ø> (ø)
test_python 66.51% <ø> (ø)
test_utils 24.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a04a98c...d537330. Read the comment docs.

@ftshijt
Copy link
Collaborator

ftshijt commented Mar 6, 2022

LGTM! Will merge it after CI passed. Thanks!

@YushiUeda
Copy link
Contributor Author

@ftshijt thanks for the review!

@ftshijt ftshijt merged commit 6f42960 into espnet:master Mar 7, 2022
@YushiUeda YushiUeda deleted the swbd_sentiment branch June 1, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ftshijt ftshijt ftshijt left review comments

Assignees
No one assigned
Labels
ESPnet2 README Recipe SLU Spoken language understanding
Projects
None yet
Milestone
v.202204
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YushiUeda @ftshijt @sw005320