Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notebook in the official doc. #4171

Merged
merged 3 commits into from
Mar 19, 2022

Conversation

ShigekiKarita
Copy link
Member

I just noticed our gh-page doc does NOT contain notebooks https://espnet.github.io/espnet/
This is because our gh action forget submodules. Moreover, the submodule was not updated for two years.

For simplicity, we should clone the latest snapshot and generate rst during build. See https://karita.xyz/espnet/ for the updated doc

image

@mergify mergify bot added Documentation CI Travis, Circle CI, etc labels Mar 19, 2022
@codecov
Copy link

codecov bot commented Mar 19, 2022

Codecov Report

Merging #4171 (0020349) into master (d23ff07) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4171   +/-   ##
=======================================
  Coverage   80.50%   80.50%           
=======================================
  Files         447      447           
  Lines       39063    39063           
=======================================
  Hits        31447    31447           
  Misses       7616     7616           
Flag Coverage Δ
test_integration_espnet1 67.13% <ø> (ø)
test_integration_espnet2 50.78% <ø> (ø)
test_python 66.77% <ø> (ø)
test_utils 24.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@sw005320 sw005320 added this to the v.0.10.7 milestone Mar 19, 2022
@sw005320
Copy link
Contributor

Thanks a lot, @ShigekiKarita!
This is a great idea!

@sw005320 sw005320 merged commit 21421e0 into espnet:master Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Travis, Circle CI, etc Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants