Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ml_openslr63 ASR recipe #4173

Merged
merged 74 commits into from
Apr 12, 2022
Merged

Add ml_openslr63 ASR recipe #4173

merged 74 commits into from
Apr 12, 2022

Conversation

bharaniuk
Copy link
Contributor

This is an espnet2 ASR recipe for the Open SLR Malayalam dataset.

@sw005320
Copy link
Contributor

Are you planning to upload a model to the Hugging Face Hub?
If so, please add a link of the model to README.md

@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #4173 (05ad575) into master (189e159) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4173   +/-   ##
=======================================
  Coverage   80.71%   80.71%           
=======================================
  Files         453      453           
  Lines       39574    39574           
=======================================
  Hits        31943    31943           
  Misses       7631     7631           
Flag Coverage Δ
test_integration_espnet1 67.13% <ø> (ø)
test_integration_espnet2 50.05% <ø> (ø)
test_python 67.16% <ø> (ø)
test_utils 24.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@rubenjohn1999
Copy link
Contributor

Hi @sw005320 @ftshijt ,

One of the CI test of the previous test set (71a08ad) failed with the following error:

Screenshot 2022-03-21 at 6 40 43 PM

However, all the other CI tests passed this stage of accessing this google drive link. So I am guessing it was a temporary issue? If there is something we need to do to fix it, please do let us know!

@sw005320 sw005320 added Recipe ASR Automatic speech recogntion labels Mar 22, 2022
@sw005320 sw005320 added this to the v.0.10.7 milestone Mar 22, 2022
@sw005320
Copy link
Contributor

LGTM.
Once it passes the CI, I'll merge it.

@bharaniuk
Copy link
Contributor Author

@sw005320 It appears that the CI is failing due to the google drive access issue again.

@mergify
Copy link
Contributor

mergify bot commented Mar 24, 2022

This pull request is now in conflict :(

@mergify mergify bot added the conflicts label Mar 24, 2022
@mergify mergify bot removed the conflicts label Mar 24, 2022
@sw005320
Copy link
Contributor

Can you merge the master?
We fixed the CI issue.

@mergify
Copy link
Contributor

mergify bot commented Mar 30, 2022

This pull request is now in conflict :(

@mergify mergify bot added the conflicts label Mar 30, 2022
@mergify mergify bot removed the conflicts label Mar 30, 2022
@bharaniuk
Copy link
Contributor Author

@sw005320 I believe that a recent PR has a PEP issue as seen in the error message
egs2/zh_openslr38/asr1/local/check_train_test_duplicate.py:35:89: E501 line too long (94 > 88 characters)
It seems to be from this PR which is why our tests seem to be failing.

@sw005320
Copy link
Contributor

Thanks a lot.
It seems like that.
Our CI was recently broken and I overlooked the issues in #4181 due to that.

@ftshijt
Copy link
Collaborator

ftshijt commented Apr 7, 2022

Could you merge the latest master branch to fix the CI?

@kan-bayashi kan-bayashi modified the milestones: v.0.10.7, v.202205 Apr 11, 2022
@ftshijt
Copy link
Collaborator

ftshijt commented Apr 12, 2022

LGTM! Many thanks

@ftshijt ftshijt merged commit ff7c051 into espnet:master Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASR Automatic speech recogntion ESPnet2 README Recipe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants