Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ICASSP2021 DNS Challenge 2 recipe #4253

Merged
merged 15 commits into from
Apr 20, 2022
Merged

Conversation

YoshikiMas
Copy link
Contributor

This PR attempts to add ICASSP2021 DNS Challenge 2 recipe.

It supports "Real – Time Denoising track", but the current recipe does not consider the latency of the enhancement model.
Implementation is almost same as in another PR.

@mergify mergify bot added the ESPnet2 label Apr 10, 2022
@Emrys365
Copy link
Collaborator

Emrys365 commented Apr 12, 2022

Could you merge the latest master branch to solve the CI error?

Also, could you add your recipe to egs2/README.md?

@mergify mergify bot added the README label Apr 15, 2022
@sw005320 sw005320 added Recipe SE Speech enhancement labels Apr 16, 2022
@sw005320 sw005320 added this to the v.202205 milestone Apr 16, 2022
Copy link
Contributor

@sw005320 sw005320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please add a README with an experimental result and model link later

@codecov
Copy link

codecov bot commented Apr 16, 2022

Codecov Report

Merging #4253 (c044abf) into master (c7881c2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4253   +/-   ##
=======================================
  Coverage   81.41%   81.41%           
=======================================
  Files         455      455           
  Lines       39739    39739           
=======================================
  Hits        32355    32355           
  Misses       7384     7384           
Flag Coverage Δ
test_integration_espnet1 67.13% <ø> (ø)
test_integration_espnet2 49.74% <ø> (ø)
test_python 68.02% <ø> (ø)
test_utils 24.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@mergify
Copy link
Contributor

mergify bot commented Apr 20, 2022

This pull request is now in conflict :(

@mergify mergify bot added the conflicts label Apr 20, 2022
@mergify mergify bot removed the conflicts label Apr 20, 2022
@sw005320 sw005320 merged commit ccdc59c into espnet:master Apr 20, 2022
@sw005320
Copy link
Contributor

Thanks, @YoshikiMas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants