Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add svoice recipe for wsj0-2mix speech separation #4257

Merged
merged 7 commits into from
Apr 22, 2022

Conversation

nateanl
Copy link
Contributor

@nateanl nateanl commented Apr 11, 2022

@mergify mergify bot added the ESPnet2 label Apr 11, 2022
@sw005320 sw005320 added New Features SE Speech enhancement labels Apr 11, 2022
@sw005320 sw005320 added this to the v.0.10.7 milestone Apr 11, 2022
@kan-bayashi kan-bayashi modified the milestones: v.0.10.7, v.202205 Apr 11, 2022
@sw005320
Copy link
Contributor

@nateanl
Copy link
Contributor Author

nateanl commented Apr 12, 2022

Sure. The model is under training, I will update the result table and upload the model once the training is finished.

@mergify mergify bot added the README label Apr 14, 2022
@nateanl
Copy link
Contributor Author

nateanl commented Apr 14, 2022

I uploaded the model to https://huggingface.co/Zhaoheng/svoice_wsj0_2mix

@sw005320 sw005320 requested a review from Emrys365 April 14, 2022 14:23
@sw005320
Copy link
Contributor

@Emrys365, can you review this PR?

@nateanl, can you add a test?

@Emrys365
Copy link
Collaborator

Sure.

Copy link
Collaborator

@Emrys365 Emrys365 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I just made some minor comments.

egs2/wsj0_2mix/enh1/README.md Outdated Show resolved Hide resolved
espnet2/enh/layers/dpmulcat.py Outdated Show resolved Hide resolved
espnet2/enh/layers/dpmulcat.py Show resolved Hide resolved
espnet2/enh/layers/dpmulcat.py Show resolved Hide resolved
espnet2/enh/layers/dpmulcat.py Outdated Show resolved Hide resolved
espnet2/enh/separator/svoice_separator.py Outdated Show resolved Hide resolved
espnet2/enh/separator/svoice_separator.py Outdated Show resolved Hide resolved
espnet2/enh/separator/svoice_separator.py Outdated Show resolved Hide resolved
@Emrys365
Copy link
Collaborator

Emrys365 commented Apr 15, 2022

Could you format the python scripts to pass black and flake8 style checks?

Also, could you add some unit tests in test/espnet2/enh/test_espnet_model.py and test/espnet2/enh/separator/test_svoice_separator.py?

You could take existing unit tests under test/espnet2/enh/ as a reference.

@codecov
Copy link

codecov bot commented Apr 17, 2022

Codecov Report

Merging #4257 (9333684) into master (ff7c051) will increase coverage by 0.07%.
The diff coverage is 98.70%.

@@            Coverage Diff             @@
##           master    #4257      +/-   ##
==========================================
+ Coverage   80.71%   80.79%   +0.07%     
==========================================
  Files         453      456       +3     
  Lines       39576    39739     +163     
==========================================
+ Hits        31945    32107     +162     
- Misses       7631     7632       +1     
Flag Coverage Δ
test_integration_espnet1 67.13% <ø> (ø)
test_integration_espnet2 49.87% <25.97%> (-0.19%) ⬇️
test_python 67.29% <98.70%> (+0.12%) ⬆️
test_utils 24.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
espnet2/enh/layers/dpmulcat.py 96.42% <96.42%> (ø)
espnet2/enh/loss/wrappers/multilayer_pit_solver.py 100.00% <100.00%> (ø)
espnet2/enh/separator/svoice_separator.py 100.00% <100.00%> (ø)
espnet2/tasks/enh.py 99.12% <100.00%> (+0.02%) ⬆️
espnet2/enh/loss/criterions/time_domain.py 92.98% <0.00%> (-3.10%) ⬇️
espnet2/st/espnet_model.py 0.00% <0.00%> (ø)
espnet2/bin/enh_scoring.py 94.20% <0.00%> (+1.44%) ⬆️
espnet2/enh/encoder/null_encoder.py 90.00% <0.00%> (+20.00%) ⬆️
espnet2/enh/decoder/null_decoder.py 100.00% <0.00%> (+28.57%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@sw005320
Copy link
Contributor

Thanks, @nateanl!

@sw005320 sw005320 merged commit 3d84d3c into espnet:master Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants