Fix aishell3 data preparation script

[LanceaKing]

No description provided.

[codecov]

Codecov Report

Merging #4277 (5a86035) into master (fba5041) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4277   +/-   ##
=======================================
  Coverage   80.71%   80.71%           
=======================================
  Files         453      453           
  Lines       39578    39578           
=======================================
  Hits        31945    31945           
  Misses       7633     7633           

Flag	Coverage Δ
test_integration_espnet1	67.13% <ø> (ø)
test_integration_espnet2	50.05% <ø> (ø)
test_python	67.16% <ø> (+0.01%)	⬆️
test_utils	24.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

[sw005320]

@LanceaKing, thanks a lot.
Could you tell me how this PR fixes the issue with an example?

[ftshijt]

I can somehow understand the intention of this fix. If we set as bool in argparse, it would be set as true as long as the argument is presented during the function call (even if it is false). The external_g2p is set as True as default, so the external_g2p will always be set as True.

[ftshijt]

LGTM! Many thanks

[LanceaKing]

I can somehow understand the intention of this fix. If we set as bool in argparse, it would be set as true as long as the argument is presented during the function call (even if it is false). The external_g2p is set as True as default, so the external_g2p will always be set as True.

As @ftshijt said, the argument external_g2p in the previous code is always True unless passing an empty string. Also, the previous code would add spaces between Chinese characters, which is not correct. @sw005320