Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accented French Openslr57 ASR recipe (ESPnet2) (part of Homework3 MNLP) #4280

Merged
merged 53 commits into from
Apr 18, 2022

Conversation

DanBerrebbi
Copy link
Contributor

No description provided.

Copy link
Contributor

@sw005320 sw005320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I have some minor comments.

egs2/accented_french_openslr56/asr1/README.md Outdated Show resolved Hide resolved
egs2/accented_french_openslr56/asr1/README.md Outdated Show resolved Hide resolved
@sw005320 sw005320 added this to the v.202205 milestone Apr 15, 2022
@sw005320 sw005320 added Recipe ASR Automatic speech recogntion labels Apr 15, 2022
@sw005320 sw005320 requested a review from ftshijt April 15, 2022 18:35
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #4280 (3a7b222) into master (15c48ab) will decrease coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4280      +/-   ##
==========================================
- Coverage   80.93%   80.71%   -0.23%     
==========================================
  Files         435      453      +18     
  Lines       37378    39585    +2207     
==========================================
+ Hits        30252    31951    +1699     
- Misses       7126     7634     +508     
Flag Coverage Δ
test_integration_espnet1 67.13% <ø> (-0.10%) ⬇️
test_integration_espnet2 50.03% <ø> (-2.46%) ⬇️
test_python 67.16% <ø> (+0.57%) ⬆️
test_utils 24.45% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
espnet2/enh/loss/criterions/time_domain.py 92.98% <0.00%> (-3.10%) ⬇️
espnet2/asr/espnet_model.py 81.44% <0.00%> (-2.06%) ⬇️
espnet2/main_funcs/average_nbest_models.py 98.30% <0.00%> (-1.70%) ⬇️
espnet2/asr/decoder/transformer_decoder.py 95.08% <0.00%> (-1.56%) ⬇️
espnet2/enh/layers/dprnn.py 98.54% <0.00%> (-1.46%) ⬇️
espnet2/tasks/asr.py 91.20% <0.00%> (-0.75%) ⬇️
espnet2/asr/encoder/transformer_encoder.py 93.61% <0.00%> (-0.59%) ⬇️
espnet2/enh/layers/tcn.py 95.90% <0.00%> (-0.37%) ⬇️
espnet2/bin/asr_inference.py 88.00% <0.00%> (-0.35%) ⬇️
espnet2/train/reporter.py 88.39% <0.00%> (-0.27%) ⬇️
... and 40 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@DanBerrebbi DanBerrebbi changed the title Accented French Openslr56 ASR recipe (ESPnet2) (part of Homework3 MNLP) Accented French Openslr57 ASR recipe (ESPnet2) (part of Homework3 MNLP) Apr 18, 2022
@ftshijt
Copy link
Collaborator

ftshijt commented Apr 18, 2022

LGTM! Many thanks

@ftshijt ftshijt merged commit 4474c3c into espnet:master Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASR Automatic speech recogntion ESPnet2 README Recipe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants