Dcase task1 Baseline #4317
Merged
Dcase task1 Baseline #4317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 25, 2022 10:56
Codecov Report
@@ Coverage Diff @@
## master #4317 +/- ##
==========================================
+ Coverage 82.41% 82.55% +0.14%
==========================================
Files 481 487 +6
Lines 41237 41846 +609
==========================================
+ Hits 33984 34548 +564
- Misses 7253 7298 +45
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
ftshijt
reviewed
Jul 5, 2022
egs2/dcase_task1/asr1/local/data.sh
Outdated
| . ./path.sh | ||
| . ./cmd.sh | ||
|
|
||
| DCASE="/ocean/projects/cis210027p/siddhana/TAU-urban-acoustic-scenes-2022-mobile-development/" |
There was a problem hiding this comment.
Could you add this entry to db.sh?
egs2/dcase_task1/asr1/local/data.sh
Outdated
| fi | ||
|
|
||
| if [ -z "${DCASE}" ]; then | ||
| log "Fill the value of 'FSC' of db.sh" |
There was a problem hiding this comment.
No this was typo, it should be DCASE. Good catch!
egs2/dcase_task1/asr1/run.sh
Outdated
Comment on lines
18
to
19
| --stage 12\ | ||
| --stop_stage 13\ |
|
Thanks a lot @ftshijt for your feedback. Yes, I believe it makes sense to add year number to the recipe. I have addressed all your comments and incorporated your suggestions. |
sw005320
reviewed
Jul 28, 2022
|
Thanks a lot, @siddhu001! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.