Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icelandic g2p #4384

Merged
merged 6 commits into from
Jun 1, 2022
Merged

Add icelandic g2p #4384

merged 6 commits into from
Jun 1, 2022

Conversation

G-Thor
Copy link
Contributor

@G-Thor G-Thor commented May 22, 2022

This pull request adds an optional icelandic g2p, installable via tools/installers/install_ice_g2p.sh
Information and code for the g2p system can be found here and here.

This g2p is used for phonemization in my recipe for the Talromur Icelandic TTS corpus, which is in a separate pull request.

Copy link
Member

@kan-bayashi kan-bayashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!
Could you fix CI and add unit test? Just extending this part:

def test_text2tokens(phoneme_tokenizer: PhonemeTokenizer):
if phoneme_tokenizer.g2p_type is None:
input = "HH AH0 L OW1 W ER1 L D"
output = ["HH", "AH0", "L", "OW1", " ", "W", "ER1", "L", "D"]

@kan-bayashi kan-bayashi self-assigned this May 22, 2022
@kan-bayashi kan-bayashi added this to the v.202205 milestone May 22, 2022
@G-Thor
Copy link
Contributor Author

G-Thor commented May 23, 2022

Tests are failing for some other feature, but linter and tests are fine for my code:
=========================== short test summary info ============================
FAILED test/espnet2/asr/frontend/test_s3prl.py::test_frontend_init - ImportEr...
FAILED test/espnet2/asr/frontend/test_s3prl.py::test_frontend_output_size - K...
FAILED test/espnet2/asr/frontend/test_s3prl.py::test_frontend_backward - KeyE...

@sw005320
Copy link
Contributor

@simpleoier, it seems that this error comes from s3prl.
Can you check it?

@kan-bayashi kan-bayashi modified the milestones: v.202205, v.202206 May 26, 2022
@simpleoier
Copy link
Collaborator

simpleoier commented May 26, 2022

Sure. I'll take a look at it.
The major reason is because the update in the s3prl. I'll update the corresponding part in espnet and submit a PR soon.

@kan-bayashi
Copy link
Member

@G-Thor could you merge master? CI is fixed.

@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #4384 (d0a08bc) into master (c9283d2) will decrease coverage by 0.01%.
The diff coverage is 23.07%.

@@            Coverage Diff             @@
##           master    #4384      +/-   ##
==========================================
- Coverage   82.58%   82.56%   -0.02%     
==========================================
  Files         469      469              
  Lines       40196    40209      +13     
==========================================
+ Hits        33194    33197       +3     
- Misses       7002     7012      +10     
Flag Coverage Δ
test_integration_espnet1 66.58% <ø> (ø)
test_integration_espnet2 49.58% <23.07%> (-0.02%) ⬇️
test_python 69.35% <23.07%> (-0.02%) ⬇️
test_utils 23.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
espnet2/text/phoneme_tokenizer.py 83.39% <23.07%> (-3.19%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@kan-bayashi kan-bayashi added Enhancement Enhancement TTS Text-to-speech labels Jun 1, 2022
@kan-bayashi kan-bayashi merged commit 8da2d8c into espnet:master Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants