Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes on batch size and num of GPUs in ESPnet2 documentation #4436

Merged
merged 5 commits into from
Jun 9, 2022

Conversation

pyf98
Copy link
Collaborator

@pyf98 pyf98 commented Jun 8, 2022

We have noticed that many users encountered this issue when using multiple GPUs on ESPnet2. Based on various investigations, ESPnet2 actually has good multi-GPU scalability, if the batch size is properly set.

Note that the behavior of batch size in ESPnet2 during multi-GPU training is different from that in ESPnet1. In ESPnet2, the total batch size is not changed regardless of the number of GPUs. Therefore, you need to manually increase the batch size if you increase the number of GPUs. Please refer to this doc for more information.

pyf98 added 4 commits June 8, 2022 15:09
Add remark on batch size and number of GPUs for ESPnet2.
Add remark on batch size and number of GPUs
Add remark on batch size and number of GPUs
doc/espnet2_tutorial.md Outdated Show resolved Hide resolved
Co-authored-by: Shinji Watanabe <sw005320@gmail.com>
@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #4436 (c95e3ee) into master (0eb7e7c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4436   +/-   ##
=======================================
  Coverage   82.77%   82.77%           
=======================================
  Files         474      474           
  Lines       40755    40755           
=======================================
  Hits        33733    33733           
  Misses       7022     7022           
Flag Coverage Δ
test_integration_espnet1 66.58% <ø> (ø)
test_integration_espnet2 49.30% <ø> (ø)
test_python 69.73% <ø> (ø)
test_utils 23.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@sw005320
Copy link
Contributor

sw005320 commented Jun 9, 2022

Thanks, @pyf98!
I believe this will mitigate the confusion regarding the multi-GPU usage!

@sw005320 sw005320 merged commit c8be876 into espnet:master Jun 9, 2022
@pyf98 pyf98 deleted the pyf98-patch-1 branch June 9, 2022 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants