-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DPTNet and WarmupStepLR scheduler #4449
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4449 +/- ##
========================================
Coverage 82.77% 82.77%
========================================
Files 474 477 +3
Lines 40755 40906 +151
========================================
+ Hits 33733 33860 +127
- Misses 7022 7046 +24
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Hi @popcornell Could you help review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me already.
The trained model has been uploaded to HuggingFace: https://huggingface.co/espnet/Wangyou_Zhang_wsj0_2mix_enh_train_enh_dptnet_raw |
I think this PR is ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Thanks! @popcornell |
This PR adds the dual-path transformer network (DPTNet) for time-domain speech separation, and the corresponding LR scheduler (I call it WarmupStepLR here) proposed in its paper.