Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DPTNet and WarmupStepLR scheduler #4449

Merged
merged 3 commits into from
Jun 23, 2022
Merged

Conversation

Emrys365
Copy link
Collaborator

This PR adds the dual-path transformer network (DPTNet) for time-domain speech separation, and the corresponding LR scheduler (I call it WarmupStepLR here) proposed in its paper.

@Emrys365 Emrys365 added New Features ESPnet2 SE Speech enhancement labels Jun 15, 2022
@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #4449 (9be1554) into master (986dadb) will increase coverage by 0.00%.
The diff coverage is 86.98%.

@@           Coverage Diff            @@
##           master    #4449    +/-   ##
========================================
  Coverage   82.77%   82.77%            
========================================
  Files         474      477     +3     
  Lines       40755    40906   +151     
========================================
+ Hits        33733    33860   +127     
- Misses       7022     7046    +24     
Flag Coverage Δ
test_integration_espnet1 66.58% <ø> (ø)
test_integration_espnet2 49.17% <26.71%> (-0.14%) ⬇️
test_python 69.78% <86.98%> (+0.05%) ⬆️
test_utils 23.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
espnet2/schedulers/warmup_step_lr.py 34.61% <34.61%> (ø)
espnet2/enh/separator/dptnet_separator.py 96.72% <96.72%> (ø)
espnet2/enh/layers/dptnet.py 100.00% <100.00%> (ø)
espnet2/tasks/abs_task.py 75.44% <100.00%> (+0.03%) ⬆️
espnet2/tasks/enh.py 99.23% <100.00%> (+<0.01%) ⬆️
espnet2/main_funcs/calculate_all_attentions.py 95.52% <0.00%> (-4.48%) ⬇️
espnet2/enh/separator/tcn_separator.py 96.77% <0.00%> (-3.23%) ⬇️
espnet2/enh/separator/dc_crn_separator.py 95.00% <0.00%> (-2.50%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@Emrys365
Copy link
Collaborator Author

Hi @popcornell Could you help review this PR?

Copy link
Contributor

@popcornell popcornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me already.

espnet2/enh/layers/dptnet.py Outdated Show resolved Hide resolved
espnet2/enh/separator/dptnet_separator.py Outdated Show resolved Hide resolved
@Emrys365
Copy link
Collaborator Author

The trained model has been uploaded to HuggingFace: https://huggingface.co/espnet/Wangyou_Zhang_wsj0_2mix_enh_train_enh_dptnet_raw

@mergify mergify bot added the README label Jun 21, 2022
@Emrys365
Copy link
Collaborator Author

I think this PR is ready to merge.

Copy link
Contributor

@popcornell popcornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Emrys365
Copy link
Collaborator Author

Thanks! @popcornell
I will merge it.

@Emrys365 Emrys365 merged commit 6d62a4a into espnet:master Jun 23, 2022
@kan-bayashi kan-bayashi added this to the v.202207 milestone Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants