Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add Aishell-2 ASR Recipe for Espnet2 #4451

Merged
merged 11 commits into from
Jun 17, 2022
Merged

Conversation

jctian98
Copy link
Contributor

Hi, dear Espnet team.
I'm trying to make a PR for Espent2 Aishell-2 recipe.
link for the dataset: https://www.aishelltech.com/aishell_2

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #4451 (40c5f69) into master (09b6f64) will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4451      +/-   ##
==========================================
+ Coverage   82.67%   82.77%   +0.09%     
==========================================
  Files         474      474              
  Lines       40755    40755              
==========================================
+ Hits        33693    33733      +40     
+ Misses       7062     7022      -40     
Flag Coverage Δ
test_integration_espnet1 66.58% <ø> (ø)
test_integration_espnet2 49.30% <ø> (ø)
test_python 69.73% <ø> (+0.50%) ⬆️
test_utils 23.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
espnet2/enh/layers/beamformer.py 84.09% <0.00%> (+0.32%) ⬆️
espnet/nets/pytorch_backend/e2e_asr_transformer.py 96.08% <0.00%> (+0.35%) ⬆️
espnet2/diar/espnet_model.py 96.29% <0.00%> (+0.61%) ⬆️
espnet2/gan_tts/vits/vits.py 100.00% <0.00%> (+0.77%) ⬆️
espnet2/enh/layers/complex_utils.py 80.73% <0.00%> (+0.91%) ⬆️
espnet2/layers/stft.py 73.73% <0.00%> (+1.01%) ⬆️
espnet2/hubert/espnet_model.py 93.13% <0.00%> (+1.96%) ⬆️
.../nets/pytorch_backend/transformer/encoder_layer.py 98.07% <0.00%> (+3.84%) ⬆️
espnet/nets/pytorch_backend/e2e_asr_maskctc.py 91.85% <0.00%> (+4.44%) ⬆️
espnet2/bin/asr_inference_k2.py 93.07% <0.00%> (+4.61%) ⬆️
... and 1 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@sw005320 sw005320 added Recipe ASR Automatic speech recogntion labels Jun 15, 2022
@sw005320 sw005320 added this to the v.202206 milestone Jun 15, 2022
@sw005320 sw005320 requested a review from ftshijt June 15, 2022 13:07
@sw005320
Copy link
Contributor

LGTM.
@ftshijt, can you take a look at this?

Once it is ready, we may merge this PR and have a follow-up PR to update a result and upload a model.

@jctian98
Copy link
Contributor Author

Hi! I have uploaded the README file and the model files for the hybrid CTC-Attention model. The results and model files of the transducer model would be updated in days.

Copy link
Collaborator

@ftshijt ftshijt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I have some minor issues and suggestions as follows:

egs2/aishell2/asr1/local/data.sh Show resolved Hide resolved
egs2/aishell2/asr1/local/data.sh Outdated Show resolved Hide resolved
@jctian98
Copy link
Contributor Author

All fixed. Thanks :)

@ftshijt
Copy link
Collaborator

ftshijt commented Jun 17, 2022

Everything looks find for me. After the CI checks, I will merge it for now as we already got some initial results. You can start another follow-up PRs for other models and results. Many thanks!

@sw005320 sw005320 merged commit 92b0b64 into espnet:master Jun 17, 2022
@sw005320
Copy link
Contributor

Thanks, @jctian98!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASR Automatic speech recogntion ESPnet2 README Recipe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants