raise more useful error in espnet2/asr/frontend/s3prl.py if s3prl is not installed #4480
Conversation
espnet2/asr/frontend/s3prl.py
Outdated
| @@ -63,7 +63,8 @@ def _get_upstream(self, frontend_conf): | |||
| if p.endswith("s3prl"): | |||
| s3prl_path = p | |||
| break | |||
| assert s3prl_path is not None | |||
| assert s3prl_path is not None, "Cannot find s3prl in your PYTHONPATH, " \ | |||
| "you can install it via pip install s3prl" | |||
There was a problem hiding this comment.
Maybe you can refer the installer in tools?
There was a problem hiding this comment.
you are right. s3prl_path should be ${YOUR_PATH2ESPNet}/espnet/tools/s3prl.
And the code above can find it rightly when you source path.sh in an ESPNet recipe.
However it cannot do it when you just pip install espnet-model-zoo and try to use the pretrained model without espnet or s3prl. We need to devise a method to point out to a s3prl git cloned directory (pip package won't work I tried).
There was a problem hiding this comment.
This means that espnet model zoo models that rely on s3prl front-ends are broken outside recipes
There was a problem hiding this comment.
Yes, you're right. I think we need to deal with this more smart way for easy inference.
@simpleoier, can you consider it?
At this moment, we can just add meaningful error messages through an installer and path.sh
@popcornell and @ftshijt, can you do it?
There was a problem hiding this comment.
I ll handle the error message right now.
Then raise an issue related to this so it can be fixed in future.
There was a problem hiding this comment.
The code now works without installing espnet (only model-zoo) but you need to git clone s3prl locally and install it from the repo. I guess it is a reasonable compromise.
Codecov Report
@@ Coverage Diff @@
## master #4480 +/- ##
==========================================
- Coverage 82.41% 82.40% -0.01%
==========================================
Files 481 481
Lines 41237 41238 +1
==========================================
- Hits 33984 33982 -2
- Misses 7253 7256 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
No description provided.