Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update char_tokenizer.py #4499

Merged
merged 1 commit into from
Jul 8, 2022
Merged

Update char_tokenizer.py #4499

merged 1 commit into from
Jul 8, 2022

Conversation

xiabingquan
Copy link
Contributor

Fix this issue

In the method text2tokens of CharTokenizer. the space_symbol is set to "<space>" and can not be changed, but the right value should be self.space_symbol.

Copy link
Collaborator

@kamo-naoyuki kamo-naoyuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@kamo-naoyuki kamo-naoyuki added the auto-merge Enable auto-merge label Jul 8, 2022
@kamo-naoyuki kamo-naoyuki added this to the v.202207 milestone Jul 8, 2022
@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #4499 (ccffc16) into master (2b00985) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4499   +/-   ##
=======================================
  Coverage   82.41%   82.41%           
=======================================
  Files         481      481           
  Lines       41237    41237           
=======================================
  Hits        33984    33984           
  Misses       7253     7253           
Flag Coverage Δ
test_integration_espnet1 66.38% <ø> (ø)
test_integration_espnet2 49.17% <100.00%> (ø)
test_python 69.41% <100.00%> (ø)
test_utils 23.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
espnet2/text/char_tokenizer.py 82.92% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@mergify mergify bot merged commit 00b0846 into espnet:master Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Enable auto-merge ESPnet2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

char_tokenizer use fixed space_symbol "<space>" instead of self.space_symbol
2 participants