Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix librispeech default path to signify auto download #4517

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

karthik19967829
Copy link
Contributor

As Librispeech recipe automatically downloads the dataset, adding downloads against the path

As Librispeech recipe automatically downloads the dataset, adding downloads against the path
@mergify mergify bot added the ESPnet2 label Jul 17, 2022
@codecov
Copy link

codecov bot commented Jul 17, 2022

Codecov Report

Merging #4517 (31ca8aa) into master (f2778f7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4517   +/-   ##
=======================================
  Coverage   82.40%   82.40%           
=======================================
  Files         481      481           
  Lines       41238    41238           
=======================================
  Hits        33982    33982           
  Misses       7256     7256           
Flag Coverage Δ
test_integration_espnet1 66.38% <ø> (ø)
test_integration_espnet2 49.17% <ø> (ø)
test_python 69.40% <ø> (ø)
test_utils 23.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@ftshijt
Copy link
Collaborator

ftshijt commented Jul 22, 2022

Sorry, I do not fully understand why the change is necessary. In my view, Librispeech is relatively large to download, it would be better for users to add their own preferences of the directory in db.sh for memory safety.

@karthik19967829
Copy link
Contributor Author

karthik19967829 commented Jul 22, 2022

Yes that's one view point . I just wanted to indicate a way to indicate that it downloads. As the db.sh header says that all datasets with downloads as path has auto download

@sw005320 sw005320 added this to the v.202207 milestone Jul 29, 2022
@sw005320
Copy link
Contributor

If we strictly follow the rule, @karthik19967829 is right.
I'll merge this PR.
Thanks, @karthik19967829!

@sw005320 sw005320 merged commit 78f96ed into espnet:master Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants