Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update checks for bias in initialization #4574

Merged
merged 3 commits into from Aug 24, 2022
Merged

Conversation

LiChenda
Copy link
Contributor

This PR is for issue #4555 . Update the check for bias weights in the model initialization.

@sw005320
Copy link
Contributor

Can you check the error message and fix it?
https://github.com/espnet/espnet/runs/7931639550?check_suite_focus=true#step:8:8138

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #4574 (ed7db10) into master (f274ebe) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4574   +/-   ##
=======================================
  Coverage   83.06%   83.06%           
=======================================
  Files         508      508           
  Lines       43654    43661    +7     
=======================================
+ Hits        36260    36267    +7     
  Misses       7394     7394           
Flag Coverage Δ
test_integration_espnet1 66.36% <ø> (ø)
test_integration_espnet2 49.53% <36.36%> (-0.01%) ⬇️
test_python 70.61% <100.00%> (+<0.01%) ⬆️
test_utils 23.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
espnet2/torch_utils/initialize.py 93.93% <100.00%> (+0.71%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@LiChenda
Copy link
Contributor Author

Can you check the error message and fix it? https://github.com/espnet/espnet/runs/7931639550?check_suite_focus=true#step:8:8138

Sure, now, it has passed all the tests.

@sw005320
Copy link
Contributor

Thanks, @LiChenda!

@sw005320 sw005320 merged commit f51b3be into espnet:master Aug 24, 2022
@LiChenda LiChenda deleted the fix_init branch May 19, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants