-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MixIT support. It is unsupervised only. Semi-supervised config is not available for now. #4619
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -737,7 +737,7 @@ if ! "${skip_eval}"; then | |
${_ref_scp} \ | ||
${_inf_scp} \ | ||
--ref_channel ${ref_channel} \ | ||
--flexible_numspk True | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just a note, I changed it because bollean args cannot be passed in this way. If some value is passed, the variable would be parsed as True, even here "False" is intended to be used. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it is better to redefine group.add_argument("--flexible_numspk", type=bool, default=False) as from espnet2.utils.types import str2bool
...
group.add_argument("--flexible_numspk", type=str2bool, default=False) |
||
--flexible_numspk true | ||
|
||
for spk in $(seq "${spk_num}"); do | ||
for protocol in ${scoring_protocol}; do | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this argument removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the
preprocessor_choices
intasks/enh.py
to determine if the preprocessor is used. Then this arguement is redundant.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. So now this argument is specified in the configuration file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right.