Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recipe config update #4621

Merged
merged 1 commit into from Sep 5, 2022
Merged

recipe config update #4621

merged 1 commit into from Sep 5, 2022

Conversation

ftshijt
Copy link
Collaborator

@ftshijt ftshijt commented Sep 5, 2022

batch_bins does not work for folded batching, need to set to batch_size to be working

@mergify mergify bot added the ESPnet2 label Sep 5, 2022
@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #4621 (0c9f202) into master (66edc59) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4621   +/-   ##
=======================================
  Coverage   83.07%   83.07%           
=======================================
  Files         508      508           
  Lines       43775    43775           
=======================================
  Hits        36364    36364           
  Misses       7411     7411           
Flag Coverage Δ
test_integration_espnet1 66.36% <ø> (ø)
test_integration_espnet2 49.53% <ø> (ø)
test_python 70.61% <ø> (ø)
test_utils 23.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ftshijt
Copy link
Collaborator Author

ftshijt commented Sep 5, 2022

Since it is a very minor update to recipe, I will directly merge it

@ftshijt ftshijt merged commit a77e44d into master Sep 5, 2022
@ftshijt ftshijt deleted the ftshijt-patch-1 branch September 5, 2022 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant