New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ASR recipe of MAGICDATA mandarin read speech #4635
Add ASR recipe of MAGICDATA mandarin read speech #4635
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4635 +/- ##
=======================================
Coverage 83.09% 83.10%
=======================================
Files 518 518
Lines 44700 44700
=======================================
+ Hits 37145 37146 +1
+ Misses 7555 7554 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
egs2/magicdata/asr1/conf/tuning/transducer/train_conformer-rnn_transducer.yaml
Outdated
Show resolved
Hide resolved
@ftshijt Hi Jiatong, thanks for the review. I'll fix these issues in future commits and train a model using the new configuration |
If you think the PR is ready, you can remove the WIP tag in the title. And I can proceed to a final review. |
The PR is not ready yet, since the training loss of the second model I trained yesterday goes up significantly after 7epoch. The 7-th epoch does seem to show better performance than the first model I trained. Now the cluster is back online, I'm training another one with a new learning rate and warmup_step. I'll let you know if the PR is ready for review. Thanks |
@ftshijt Hi Jiatong, this PR is now ready for review. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for the contribution. LGTM! I will merge it once the CI is passed
@ftshijt Seems like the CI script itself could be broken? All recent commits to the master branch failed to pass CI. |
Yeah, understand, we will have people working on fixing the CI. Please allow some time for it to be fixed. |
@ftshijt Hi, the model has been uploaded to HuggingFace. No further PR is needed :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems to be good on my side. Will be wait the CI to be fixed
Can you merge the latest Commit to fix the CI issues? |
@ftshijt Hi, sorry for the late reply and thanks for merging it for me! |
http://www.openslr.org/68/
Most of the code is copied from aishell2 recipe
TODOs: