Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ASR recipe of MAGICDATA mandarin read speech #4635

Merged
merged 20 commits into from Sep 24, 2022

Conversation

tjysdsg
Copy link
Contributor

@tjysdsg tjysdsg commented Sep 12, 2022

http://www.openslr.org/68/

Most of the code is copied from aishell2 recipe

TODOs:

  • Store training results in README.md
    • Preliminary results
    • Fix training loss "hill climb"
  • Automatically download data and unzip

@mergify mergify bot added the ESPnet2 label Sep 12, 2022
@sw005320 sw005320 added Recipe ASR Automatic speech recogntion labels Sep 12, 2022
@sw005320 sw005320 added this to the v.202209 milestone Sep 12, 2022
@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #4635 (17f568c) into master (ef6c15f) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4635   +/-   ##
=======================================
  Coverage   83.09%   83.10%           
=======================================
  Files         518      518           
  Lines       44700    44700           
=======================================
+ Hits        37145    37146    +1     
+ Misses       7555     7554    -1     
Flag Coverage Δ
test_integration_espnet1 66.37% <ø> (ø)
test_integration_espnet2 49.36% <ø> (ø)
test_python 70.92% <ø> (+<0.01%) ⬆️
test_utils 23.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
espnet/distributed/pytorch_backend/launch.py 83.90% <0.00%> (+1.14%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

egs2/magicdata/asr1/conf/train_asr_conformer.yaml Outdated Show resolved Hide resolved
egs2/magicdata/asr1/local/data.sh Outdated Show resolved Hide resolved
egs2/magicdata/asr1/run.sh Outdated Show resolved Hide resolved
@tjysdsg
Copy link
Contributor Author

tjysdsg commented Sep 13, 2022

@ftshijt Hi Jiatong, thanks for the review. I'll fix these issues in future commits and train a model using the new configuration

@mergify mergify bot added the README label Sep 14, 2022
@ftshijt
Copy link
Collaborator

ftshijt commented Sep 17, 2022

If you think the PR is ready, you can remove the WIP tag in the title. And I can proceed to a final review.

@tjysdsg
Copy link
Contributor Author

tjysdsg commented Sep 17, 2022

If you think the PR is ready, you can remove the WIP tag in the title. And I can proceed to a final review.

The PR is not ready yet, since the training loss of the second model I trained yesterday goes up significantly after 7epoch. The 7-th epoch does seem to show better performance than the first model I trained.

Now the cluster is back online, I'm training another one with a new learning rate and warmup_step. I'll let you know if the PR is ready for review. Thanks

@tjysdsg
Copy link
Contributor Author

tjysdsg commented Sep 20, 2022

@ftshijt Hi Jiatong, this PR is now ready for review. Thanks!

@tjysdsg tjysdsg changed the title [WIP] Add ASR recipe of MAGICDATA mandarin read speech Add ASR recipe of MAGICDATA mandarin read speech Sep 20, 2022
Copy link
Collaborator

@ftshijt ftshijt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the contribution. LGTM! I will merge it once the CI is passed

egs2/magicdata/asr1/README.md Show resolved Hide resolved
@tjysdsg
Copy link
Contributor Author

tjysdsg commented Sep 20, 2022

@ftshijt Seems like the CI script itself could be broken? All recent commits to the master branch failed to pass CI.

@ftshijt
Copy link
Collaborator

ftshijt commented Sep 20, 2022

Yeah, understand, we will have people working on fixing the CI. Please allow some time for it to be fixed.

@tjysdsg
Copy link
Contributor Author

tjysdsg commented Sep 21, 2022

@ftshijt Hi, the model has been uploaded to HuggingFace. No further PR is needed :)

Copy link
Collaborator

@ftshijt ftshijt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be good on my side. Will be wait the CI to be fixed

@ftshijt
Copy link
Collaborator

ftshijt commented Sep 23, 2022

Can you merge the latest Commit to fix the CI issues?

@tjysdsg
Copy link
Contributor Author

tjysdsg commented Sep 24, 2022

@ftshijt Hi, sorry for the late reply and thanks for merging it for me!

@ftshijt ftshijt merged commit 3288274 into espnet:master Sep 24, 2022
@tjysdsg tjysdsg deleted the magicdata_mandarin_read_speech branch October 5, 2022 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASR Automatic speech recogntion ESPnet2 README Recipe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants