Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qasr update #4642

Merged
merged 11 commits into from Sep 24, 2022
Merged

qasr update #4642

merged 11 commits into from Sep 24, 2022

Conversation

massabaali7
Copy link
Contributor

🕯️

ftshijt
ftshijt reviewed Sep 18, 2022
View reviewed changes
egs2/qasr_tts/tts1/conf/tuning/train_fastspeech2.yaml Outdated Show resolved Hide resolved
egs2/qasr_tts/tts1/local/data_download.sh Show resolved Hide resolved
egs2/qasr_tts/tts1/local/data_download.sh Outdated Show resolved Hide resolved
egs2/qasr_tts/tts1/run.sh Outdated Show resolved Hide resolved
ftshijt
ftshijt reviewed Sep 19, 2022
View reviewed changes
Copy link
Collaborator

@ftshijt ftshijt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add the dataset in egs2/README.md

egs2/qasr_tts/tts1/conf/tuning/train_conformer_fastspeech.yaml Show resolved Hide resolved
egs2/qasr_tts/tts1/local/data.sh Outdated Show resolved Hide resolved
egs2/qasr_tts/tts1/local/data.sh Outdated Show resolved Hide resolved
egs2/qasr_tts/tts1/local/data.sh Outdated Show resolved Hide resolved
egs2/qasr_tts/tts1/run.sh Outdated Show resolved Hide resolved
massabaali7 and others added 5 commits September 20, 2022 11:20
@massabaali7 @ftshijt
Update egs2/qasr_tts/tts1/local/data.sh
7ee2f84 
Co-authored-by: Jiatong <728307998@qq.com>
@massabaali7 @ftshijt
Update egs2/qasr_tts/tts1/local/data.sh
160e9f2 
Co-authored-by: Jiatong <728307998@qq.com>
@massabaali7 @ftshijt
Update egs2/qasr_tts/tts1/run.sh
7ca298f 
Co-authored-by: Jiatong <728307998@qq.com>
@massabaali7
Update README.MD
511ba69
@ftshijt
Merge branch 'master' into master
eee5ad0
@codecov
Copy link

codecov bot commented Sep 23, 2022 •
edited

Codecov Report

Merging #4642 (7b90841) into master (ef6c15f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4642   +/-   ##
=======================================
  Coverage   83.09%   83.09%           
=======================================
  Files         518      518           
  Lines       44700    44700           
=======================================
  Hits        37145    37145           
  Misses       7555     7555
Flag Coverage Δ
test_integration_espnet1 66.37% <ø> (ø)
test_integration_espnet2 49.36% <ø> (ø)
test_python 70.91% <ø> (ø)
test_utils 23.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ftshijt
Copy link
Collaborator

ftshijt commented Sep 24, 2022

As the CI suggested, could you add a symlink to tts_train.py: error: No such file: egs2/qasr_tts/tts1/conf/train.yaml

@ftshijt
Copy link
Collaborator

ftshijt commented Sep 24, 2022

Many thanks for your contribution! PR merged

@ftshijt ftshijt merged commit 08eacbf into espnet:master Sep 24, 2022
@massabaali7
Copy link
Contributor Author

Many thanks for you superstar @ftshijt !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ftshijt ftshijt ftshijt left review comments

Assignees
No one assigned
Labels
ESPnet1 ESPnet2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@massabaali7 @ftshijt