Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Muskit: rename & reorganize features #4668

Merged
merged 4 commits into from Sep 27, 2022
Merged

Muskit: rename & reorganize features #4668

merged 4 commits into from Sep 27, 2022

Conversation

A-Quarter-Mile
Copy link
Contributor

Hi @ftshijt, here are new updates.

  • Add model naive_rnn_dp. All stages have been tested. Result sounds great after 100 epochs. The rest is still running.
  • Add new feature beat.
  • Add SyllableScoreFeats.
  • Reorganize two sets of features by segmenting from label or from xml.
  • Unify feature names, mainly focusing on label and midi.

@mergify mergify bot added the ESPnet2 label Sep 27, 2022
ftshijt
ftshijt reviewed Sep 27, 2022
View reviewed changes
Copy link
Collaborator

@ftshijt ftshijt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM! Thanks for the update. Have some minor issues, probably you can add it into TODOs.

espnet2/train/preprocessor.py Outdated Show resolved Hide resolved
espnet2/train/preprocessor.py Outdated Show resolved Hide resolved
espnet2/train/preprocessor.py Show resolved Hide resolved
espnet2/bin/svs_inference.py Show resolved Hide resolved
espnet2/bin/svs_inference.py Show resolved Hide resolved
@ftshijt
Copy link
Collaborator

ftshijt commented Sep 27, 2022

After this PR, I think we can start to work on the merging towards the master branch :-)

A-Quarter-Mile and others added 3 commits September 28, 2022 00:15
@A-Quarter-Mile @ftshijt
Update espnet2/train/preprocessor.py
99fd1e7 
Co-authored-by: Jiatong <728307998@qq.com>
@A-Quarter-Mile @ftshijt
Update espnet2/train/preprocessor.py
2b7ac55 
Co-authored-by: Jiatong <728307998@qq.com>
@A-Quarter-Mile
add TODO
3f26d18
@ftshijt
Copy link
Collaborator

ftshijt commented Sep 27, 2022

Many thanks!

@ftshijt ftshijt merged commit a85eb82 into espnet:muskits Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ftshijt ftshijt ftshijt left review comments

Assignees
No one assigned
Labels
ESPnet2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@A-Quarter-Mile @ftshijt