Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VISinger #4689

Merged
merged 85 commits into from Jan 3, 2023
Merged

VISinger #4689

merged 85 commits into from Jan 3, 2023

Conversation

jerryuhoo
Copy link
Contributor

@jerryuhoo jerryuhoo commented Oct 4, 2022 •
edited

Implement VISinger model

@mergify mergify bot added the ESPnet2 label Oct 4, 2022
ftshijt
ftshijt requested changes Oct 4, 2022
View reviewed changes
egs2/ofuton_p_utagoe_db/svs1/conf/tuning/train_vits.yaml Outdated Show resolved Hide resolved
egs2/ofuton_p_utagoe_db/svs1/run.sh Outdated Show resolved Hide resolved
egs2/ofuton_p_utagoe_db/svs1/run.sh Outdated Show resolved Hide resolved
espnet2/gan_svs/espnet_model.py Show resolved Hide resolved
espnet2/gan_svs/hifigan/__init__.py Outdated Show resolved Hide resolved
espnet2/gan_svs/hifigan/hifigan.py Outdated Show resolved Hide resolved
espnet2/gan_svs/hifigan/loss.py Outdated Show resolved Hide resolved
espnet2/gan_svs/hifigan/residual_block.py Outdated Show resolved Hide resolved
espnet2/gan_svs/jets/alignments.py Outdated Show resolved Hide resolved
@ftshijt ftshijt added New Features Music Music processing labels Oct 4, 2022
@ftshijt ftshijt changed the title VISinger draft [WIP] VISinger draft Oct 4, 2022
@jerryuhoo
fix config
2ce4419
@jerryuhoo
add gan_svs inference
c23e2b8 
note that dict is used instead of tuple, according to the latest vits model format, which may affect other svs models.
@jerryuhoo
Change duplicate code to symbolic links
c02206d
@jerryuhoo
fix svs.sh indent
6a8763f
ftshijt
ftshijt reviewed Oct 6, 2022
View reviewed changes
espnet2/gan_svs/vits/posterior_encoder.py Outdated Show resolved Hide resolved
espnet2/gan_svs/vits/text_encoder.py Show resolved Hide resolved
espnet2/tasks/svs.py Show resolved Hide resolved
ftshijt
ftshijt reviewed Oct 6, 2022
View reviewed changes
egs2/ofuton_p_utagoe_db/svs1/run.sh Outdated Show resolved Hide resolved
espnet2/gan_svs/vits/monotonic_align Outdated Show resolved Hide resolved
espnet2/gan_svs/vits/generator.py Show resolved Hide resolved
@mergify mergify bot added ESPnet1 README CI Travis, Circle CI, etc Installation labels Oct 10, 2022
@mergify
Copy link
Contributor

mergify bot commented Dec 9, 2022

This pull request is now in conflict :(

@mergify mergify bot added the conflicts label Dec 9, 2022
@mergify mergify bot removed the conflicts label Dec 11, 2022
@ftshijt ftshijt changed the title [WIP] VISinger draft [WIP] VISinger Dec 13, 2022
@jerryuhoo
Copy link
Contributor Author

stage 8 (evaluation) causes an error because the names of ground truth wav files differ from generated files.

@ftshijt ftshijt changed the title [WIP] VISinger VISinger Dec 19, 2022
ftshijt
ftshijt reviewed Dec 20, 2022
View reviewed changes
Copy link
Collaborator

@ftshijt ftshijt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the update! The implementation is cool. I only have some minor comments. Please fix them, then we can get into the next stage. Good job!

egs2/TEMPLATE/svs1/svs.sh Show resolved Hide resolved
egs2/TEMPLATE/svs1/svs.sh Outdated Show resolved Hide resolved
egs2/TEMPLATE/svs1/svs.sh Outdated Show resolved Hide resolved
egs2/TEMPLATE/svs1/svs.sh Outdated Show resolved Hide resolved
espnet2/bin/svs_inference.py Outdated Show resolved Hide resolved
espnet2/bin/svs_inference.py Outdated Show resolved Hide resolved
espnet2/gan_svs/vits/duration_predictor.py Show resolved Hide resolved
espnet2/gan_svs/vits/generator.py Outdated Show resolved Hide resolved
espnet2/tasks/gan_svs.py Outdated Show resolved Hide resolved
espnet2/tasks/svs.py Outdated Show resolved Hide resolved
@ftshijt
Copy link
Collaborator

ftshijt commented Jan 3, 2023

After you fixes the two issues pointed out, I will merge this PR and we can work on the one that merges into the master branch.

@ftshijt ftshijt merged commit ee6e0ac into espnet:visinger Jan 3, 2023
@jerryuhoo jerryuhoo deleted the muskits branch January 11, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ftshijt ftshijt ftshijt requested changes

Assignees
No one assigned
Labels
CI Travis, Circle CI, etc ESPnet1 ESPnet2 Installation Music Music processing New Features README
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jerryuhoo @ftshijt @soumimaiti @kan-bayashi @sophia1488 @kamo-naoyuki