Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add espnet2 TTS recipe on M-AILABS #4701

Merged
merged 12 commits into from Oct 30, 2022
Merged

Conversation

Takaaki-Saeki
Copy link
Contributor

@Takaaki-Saeki Takaaki-Saeki commented Oct 9, 2022

This PR adds a TTS recipe on M-AILABS.
TTS recipes on M-AILABS was supported in espnet1 but not supported in espnet2.

This recipe only uses a en_US single-speaker data.
I have uploaded a pretrained Tacotron2 model to HuggingFace.

I also prepared a script for multilingual data preparation: local/data_multilingual.sh to train a TTS model on the whole dataset.

@mergify mergify bot added the ESPnet2 label Oct 9, 2022
@Takaaki-Saeki Takaaki-Saeki changed the title Add TTS recipe on M-AILABS Add espnet2 TTS recipe on M-AILABS Oct 9, 2022
@Takaaki-Saeki Takaaki-Saeki marked this pull request as ready for review October 9, 2022 21:48
@mergify mergify bot added the README label Oct 9, 2022
@codecov
Copy link

codecov bot commented Oct 9, 2022

Codecov Report

Merging #4701 (0418427) into master (e9d583b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4701   +/-   ##
=======================================
  Coverage   80.45%   80.45%           
=======================================
  Files         527      527           
  Lines       46215    46219    +4     
=======================================
+ Hits        37181    37185    +4     
  Misses       9034     9034           
Flag Coverage Δ
test_integration_espnet1 66.37% <ø> (ø)
test_integration_espnet2 49.05% <0.00%> (-0.01%) ⬇️
test_python 68.66% <100.00%> (+<0.01%) ⬆️
test_utils 23.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
espnet2/text/phoneme_tokenizer.py 82.15% <100.00%> (+0.26%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sw005320 sw005320 added this to the v.202211 milestone Oct 10, 2022
@sw005320 sw005320 added Recipe TTS Text-to-speech labels Oct 10, 2022
@ftshijt
Copy link
Collaborator

ftshijt commented Oct 10, 2022

Looks great! Some minor suggestion: given that the local/data.sh is automatically called in the TEMPLATE, how about combine data.sh and data_multilingual.sh but with an additional augment? In that way, we can change the config simply by change the --local_data_opts

In addition, could you also update the entry in egs2/TEMPLATE/README.md ?

@Takaaki-Saeki
Copy link
Contributor Author

Thanks for the suggestion!
I have merged the en_us and multilingual recipes.
Also updated the readme.

@Takaaki-Saeki
Copy link
Contributor Author

Hmm... it seems that some tests regarding espnet2/slu/test_transcript_espnet_model.py are not successful.

@sw005320
Copy link
Contributor

Hmm... it seems that some tests regarding espnet2/slu/test_transcript_espnet_model.py are not successful.

@siddhu001, could you check this?
some interfaces are changed?

@siddhu001
Copy link
Collaborator

@sw005320 It seems to be problem with hugging face.

E       TypeError: register_buffer() got an unexpected keyword argument 'persistent'
tools/venv/lib/python3.7/site-packages/transformers/models/bert/modeling_bert.py:198: TypeError

I think it is because of some huggingface version update. I am looking into this. @Takaaki-Saeki if you have any suggestions, please let me know!

@mergify mergify bot added the ESPnet1 label Oct 12, 2022
@Takaaki-Saeki
Copy link
Contributor Author

Hi @siddhu001,

I think it is related to the version of PyTorch.
BertEmbeddings class requires persistent=false in nn.Module.register_buffer().
See this.

But this arg is not implemented in PyTorch v1.5.0 (see this), and it is introduced in v1.6.0 (see this).

So could you take a look at the pytorch version?

@ftshijt
Copy link
Collaborator

ftshijt commented Oct 30, 2022

Many thanks! Merged.

@ftshijt ftshijt merged commit a25ad80 into espnet:master Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants