Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for OCR task on IAM handwriting dataset #4707

Merged
merged 13 commits into from Nov 6, 2022

Conversation

kenzheng99
Copy link
Contributor

@kenzheng99 kenzheng99 commented Oct 11, 2022

Current best performance is about 6.8 CER, which is still a bit off from SOTA results on this dataset. Let me know if anyone has suggestions for further performance tuning of this recipe.

@sw005320
Copy link
Contributor

@sw005320 sw005320 requested a review from ftshijt October 28, 2022 17:41
@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #4707 (2169367) into master (143c946) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4707      +/-   ##
==========================================
+ Coverage   80.31%   80.32%   +0.01%     
==========================================
  Files         527      527              
  Lines       46311    46311              
==========================================
+ Hits        37193    37200       +7     
+ Misses       9118     9111       -7     
Flag Coverage Δ
test_integration_espnet1 66.37% <ø> (+0.13%) ⬆️
test_integration_espnet2 48.96% <ø> (+0.11%) ⬆️
test_python 68.56% <ø> (ø)
test_utils 23.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
espnet/tts/pytorch_backend/tts.py 78.63% <0.00%> (+0.29%) ⬆️
...et/nets/pytorch_backend/e2e_asr_mix_transformer.py 84.97% <0.00%> (+0.46%) ⬆️
espnet/asr/asr_utils.py 76.53% <0.00%> (+0.87%) ⬆️
...pnet/nets/pytorch_backend/transformer/optimizer.py 88.88% <0.00%> (+2.77%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@ftshijt ftshijt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool PR! Could you please also update the corresponding entry in egs2/TEMPLATE/README.md

egs2/iam/ocr1/local/data.sh Show resolved Hide resolved
egs2/iam/ocr1/local/data.sh Outdated Show resolved Hide resolved
egs2/iam/ocr1/run.sh Outdated Show resolved Hide resolved
egs2/iam/ocr1/run.sh Outdated Show resolved Hide resolved
@mergify
Copy link
Contributor

mergify bot commented Oct 30, 2022

This pull request is now in conflict :(

@mergify mergify bot added the conflicts label Oct 30, 2022
@mergify mergify bot removed the conflicts label Oct 30, 2022
@sw005320
Copy link
Contributor

@kenzheng99, could you reflect @ftshijt's comments?

- pytorch version: `pytorch 1.10.0`
- Git hash: `5a6319300231b8193f1b6e8465d572be63150119`
- Commit date: `Sat Sep 24 12:14:08 2022 -0400`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a pre-trained model?

@mergify
Copy link
Contributor

mergify bot commented Nov 2, 2022

This pull request is now in conflict :(

@mergify mergify bot added the conflicts label Nov 2, 2022
@mergify mergify bot removed the conflicts label Nov 3, 2022
@sw005320
Copy link
Contributor

sw005320 commented Nov 3, 2022

Please reflect the comments ($IAM issue and model upload).

@kenzheng99
Copy link
Contributor Author

kenzheng99 commented Nov 4, 2022

Updated the last comment! For model upload, I have just made a HuggingFace account (username is kenzheng99) and requested access to the ESPnet org, once I get that I can upload my model.

@ftshijt
Copy link
Collaborator

ftshijt commented Nov 6, 2022

Updated the last comment! For model upload, I have just made a HuggingFace account (username is kenzheng99) and requested access to the ESPnet org, once I get that I can upload my model.

Very cool! You can make a separate PR for the update of the link. Will merge this PR. Many thanks for your contribution!

@ftshijt ftshijt merged commit b221db0 into espnet:master Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants