New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Recipe PR] MELD: Multimodal EmotionLines Dataset #4771
Conversation
@siddhu001, it would be great if you also review this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm: it seems that this is only an unimodal model. Is it intentional or you will keep update it.
I also recommend you to check the task of SLU, which could be a better place to hold your recipe as well (we can keep on this).
I would suggest incorporating all of Jiatong's feedback. I added a comment and clarification, rest looks good to me. |
Yes, this recipe is designed to use unimodal to do multitask learning is ASR and SLU. We may not update MELD to involve multimodals.
Thanks for mentioning, I categorized this recipe as SLU in egs2/README.md. |
@ftshijt, can you review it again? |
Looks cool! After it passed the CI tests, I will merge it |
Seems it fails the CI test, as well as centos7 and debian9 tests due to the overlength lines in update: should be fixed now! |
Hi @ftshijt, thank you for your review! I fixed the flake8 error |
Codecov Report
@@ Coverage Diff @@
## master #4771 +/- ##
=======================================
Coverage 80.32% 80.32%
=======================================
Files 530 530
Lines 46527 46527
=======================================
Hits 37372 37372
Misses 9155 9155
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
The failed check may be caused by this issue reported in the latest version of numpy. |
Thanks, @realzza! |
About
Added baseline recipe for MELD: Multimodal EmotionLines Dataset
Checklist
black espnet espnet2 test utils setup.py egs*/*/*/local egs2/TEMPLATE/*/pyscripts tools/*.py ci/*.py
isort espnet espnet2 test utils setup.py egs*/*/*/local egs2/TEMPLATE/*/pyscripts tools/*.py ci/*.py
egs/README.md
oregs2/README.md
with corresponding recipesegs2/TEMPLATE/db.sh
for a new corpusTodo