Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Architectures for ST #4815

Merged
merged 175 commits into from Jul 26, 2023
Merged

New Architectures for ST #4815

merged 175 commits into from Jul 26, 2023

Conversation

brianyan918
Copy link
Contributor

@brianyan918 brianyan918 commented Dec 8, 2022 •
edited

This PR primarily modifies espnet2/st/espnet_model.py and espnet2/bin/st_inference.py to support more architectures:

  • multi-decoder
  • ST CTC
  • RNN-T

Results:

@sw005320 sw005320 added ST Speech translation New Features labels Dec 9, 2022
@sw005320 sw005320 added this to the v.202211 milestone Dec 9, 2022
@kan-bayashi kan-bayashi modified the milestones: v.202211, v.202301 Dec 11, 2022
@brianyan918 brianyan918 changed the title support multi-decoder 2-pass ST New Architectures for ST Dec 16, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 17, 2023

This pull request is now in conflict :(

@mergify mergify bot added the conflicts label Jan 17, 2023
@kan-bayashi kan-bayashi modified the milestones: v.202301, v.202303 Feb 1, 2023
@mergify mergify bot added the Installation label Jul 7, 2023
@sw005320
Copy link
Contributor

LGTM!
Sorry that currently, our CI is broken.
After it is fixed, I'll merge this PR.

@sw005320 sw005320 added the auto-merge Enable auto-merge label Jul 20, 2023
@sw005320
Copy link
Contributor

Hi @brianyan918
It would be good to finish this PR as soon as possible.
Could you fix the CI error and finish this PR?

@brianyan918
Copy link
Contributor Author

Hi @brianyan918
It would be good to finish this PR as soon as possible.
Could you fix the CI error and finish this PR?

Ok! Will do it in the evening today

@sw005320
Copy link
Contributor

@brianyan918, I'd recommend you run some tests locally.
https://github.com/espnet/espnet/blob/master/CONTRIBUTING.md

@brianyan918
Copy link
Contributor Author

@brianyan918, I'd recommend you run some tests locally. https://github.com/espnet/espnet/blob/master/CONTRIBUTING.md

I had a naming conflict. Locally, the individual test worked. But when CI ran all the tests, this issue popped up.

@sw005320
Copy link
Contributor

I see.

@mergify mergify bot merged commit aeea04d into espnet:master Jul 26, 2023
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sw005320 sw005320 sw005320 left review comments

@b-flo b-flo b-flo left review comments

@ftshijt ftshijt ftshijt approved these changes

Assignees
No one assigned
Labels
auto-merge Enable auto-merge ESPnet1 ESPnet2 Installation New Features README ST Speech translation
Projects
None yet
Milestone
v.202307
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@brianyan918 @ftshijt @sw005320 @b-flo @kan-bayashi