Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning statement when the hypo length equals to the max out length. #4843

Merged
merged 1 commit into from Dec 29, 2022

Conversation

pengchengguo
Copy link
Collaborator

Add a warning statement when the hypo length equals the max out length.
The user should consider increasing the maxlenratio to avoid the decoding being stopped incorrectly by the max out length limitation.

@mergify mergify bot added the ESPnet1 label Dec 29, 2022
@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Merging #4843 (ea03d3d) into master (bdd7ab6) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #4843      +/-   ##
==========================================
- Coverage   80.63%   80.63%   -0.01%     
==========================================
  Files         536      536              
  Lines       47517    47523       +6     
==========================================
+ Hits        38315    38319       +4     
- Misses       9202     9204       +2     
Flag Coverage Δ
test_integration_espnet1 66.39% <100.00%> (+<0.01%) ⬆️
test_integration_espnet2 48.56% <50.00%> (+<0.01%) ⬆️
test_python 69.17% <66.66%> (-0.01%) ⬇️
test_utils 23.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
espnet/nets/batch_beam_search_online_sim.py 91.36% <33.33%> (-1.29%) ⬇️
espnet/nets/beam_search.py 98.21% <100.00%> (+0.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sw005320 sw005320 added this to the v.202301 milestone Dec 29, 2022
@sw005320
Copy link
Contributor

Thanks!
@brianyan918, can you also add the same warning for ST/MT?
We could avoid the maximum output length issue in the ST/MT side.

@sw005320 sw005320 added Enhancement Enhancement ASR Automatic speech recogntion labels Dec 29, 2022
@sw005320 sw005320 merged commit b12e08c into espnet:master Dec 29, 2022
@pengchengguo pengchengguo deleted the decode_warning branch January 3, 2023 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASR Automatic speech recogntion Enhancement Enhancement ESPnet1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants