Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add torchaudio version check for HuBERT pretraining #4872

Merged
merged 1 commit into from Jan 18, 2023

Conversation

simpleoier
Copy link
Collaborator

@simpleoier simpleoier commented Jan 17, 2023

This is as suggested in #4747

          This is true. I suggest checking if torchaudio is 0.13.1 or nightly version, not only because of the AMP issue, but also there is new model initialization which is important to HuBERT pre-training.

Originally posted by @nateanl in #4747 (comment)

@mergify mergify bot added the ESPnet2 label Jan 17, 2023
@sw005320 sw005320 added the auto-merge Enable auto-merge label Jan 17, 2023
@sw005320 sw005320 added this to the v.202301 milestone Jan 17, 2023
@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #4872 (86b51e9) into master (99cea47) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4872   +/-   ##
=======================================
  Coverage   78.80%   78.80%           
=======================================
  Files         577      577           
  Lines       51659    51659           
=======================================
  Hits        40710    40710           
  Misses      10949    10949           
Flag Coverage Δ
test_integration_espnet1 66.38% <ø> (ø)
test_integration_espnet2 48.12% <ø> (ø)
test_python 68.27% <ø> (ø)
test_utils 23.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot merged commit 9ec35ac into espnet:master Jan 18, 2023
@simpleoier simpleoier deleted the hubert branch January 28, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Enable auto-merge ESPnet2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants