Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new EGS2 recipe 'reazonspeech' #4885

Merged
merged 4 commits into from Feb 1, 2023

Conversation

fujimotos
Copy link
Contributor

ReazonSpeech is >19000h Japanese corpus collected from TV programs.
This adds ASR recipe that trains Conformer model on it.

  • The dataset is automatically downloaded from Hugging Face using
    datasets.load_download()

  • The training recipe is almost the same as CSJ, except for minor
    parameter tweakings (to optimize it for our machine spec)

The pre-trained model is available on Hugging Face:

https://huggingface.co/reazon-research/reazonspeech-espnet-v1

@sw005320 sw005320 requested a review from ftshijt January 25, 2023 01:00
@sw005320 sw005320 added Recipe ASR Automatic speech recogntion labels Jan 25, 2023
@sw005320 sw005320 added this to the v.202301 milestone Jan 25, 2023
egs2/reazonspeech/asr1/local/data.sh Outdated Show resolved Hide resolved
egs2/reazonspeech/asr1/local/path.sh Outdated Show resolved Hide resolved
@ftshijt
Copy link
Collaborator

ftshijt commented Jan 31, 2023

Hi @fujimotos Please fix the CI, then I can merge it~ Thanks

@mergify
Copy link
Contributor

mergify bot commented Jan 31, 2023

This pull request is now in conflict :(

@mergify mergify bot added the conflicts label Jan 31, 2023
Fujimoto Seiji and others added 4 commits February 1, 2023 09:29
ReazonSpeech is >19000h Japanese corpus collected from TV programs.
This adds ASR recipe that trains Conformer model on it.

 * The dataset is automatically downloaded from Hugging Face using
   `datasets.load_download()`

 * The training recipe is almost the same as CSJ, except for minor
   parameter tweakings (to optimize it for our machine spec)

The pre-trained model is available on Hugging Face:

https://huggingface.co/reazon-research/reazonspeech-espnet-v1

Signed-off-by: Fujimoto Seiji <fujimoto@clear-code.com>
Based on a feedback on PR#4885. Instead of hard-cording the data path,
make it adjustable by db.sh

Signed-off-by: Fujimoto Seiji <fujimoto@clear-code.com>
Based on a feedback on PR#4885. Instead of letting users find out
how to install the required modules by themselves, let's automate
those steps.

Signed-off-by: Fujimoto Seiji <fujimoto@clear-code.com>
This resolves coding-style warnings emitted by linters:

 * Quote the `test_sets` variable to resolve a shellcheck worning.
 * Apply isort and black to reformat `local/data.py`.

Signed-off-by: Fujimoto Seiji <fujimoto@ceptord.net>
@sw005320
Copy link
Contributor

sw005320 commented Feb 1, 2023

tools/installers/install_datasets.sh seems to be empty.
Is it OK?

@fujimotos
Copy link
Contributor Author

Hi @fujimotos Please fix the CI, then I can merge it~ Thanks

@ftshijt The CI error should be fixed by a92301e:

  • Added a pair of quotation marks to pass shellcheck.
  • Applied isort and black to follow the coding standard.

Also I fixed the merge conflict by rebasing to the master HEAD,
so that you can merge this PR cleanly.

Feel free to ask me if anything is not clear!

@fujimotos
Copy link
Contributor Author

tools/installers/install_datasets.sh seems to be empty.
Is it OK?

@sw005320 It must be OK.

Basically @wanchichen added install_datasets.sh in 8757bf6, but
did not turned on the executable bit on the script file. For this reason,
the following command did not work previously:

Error: it seems that datasets is not installed.
Error: please install datasets as follows.
Error: cd ${MAIN_ROOT}/tools/installers && ./install_datasets.sh

So I did chmod +x install_datasets.sh as part of this PR (so that
users actually can execute ./install_datasets.sh). This is why Git shows
an "empty" diff.

@sw005320
Copy link
Contributor

sw005320 commented Feb 1, 2023

Got it. Thanks!

@sw005320 sw005320 added the auto-merge Enable auto-merge label Feb 1, 2023
@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Merging #4885 (a92301e) into master (2270dee) will increase coverage by 9.52%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4885      +/-   ##
==========================================
+ Coverage   67.06%   76.58%   +9.52%     
==========================================
  Files         603      603              
  Lines       53737    53737              
==========================================
+ Hits        36039    41155    +5116     
+ Misses      17698    12582    -5116     
Flag Coverage Δ
test_integration_espnet1 66.33% <ø> (?)
test_integration_espnet2 47.60% <ø> (?)
test_python 66.45% <ø> (+0.09%) ⬆️
test_utils 23.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
espnet2/train/reporter.py 88.44% <0.00%> (+0.26%) ⬆️
espnet2/svs/espnet_model.py 6.25% <0.00%> (+0.52%) ⬆️
espnet/nets/pytorch_backend/e2e_tts_transformer.py 88.79% <0.00%> (+0.56%) ⬆️
espnet/nets/pytorch_backend/e2e_asr_transformer.py 95.72% <0.00%> (+0.71%) ⬆️
espnet/asr/pytorch_backend/asr_init.py 90.64% <0.00%> (+0.71%) ⬆️
espnet/nets/pytorch_backend/e2e_asr.py 80.29% <0.00%> (+0.74%) ⬆️
espnet2/train/iterable_dataset.py 85.47% <0.00%> (+0.85%) ⬆️
espnet/nets/pytorch_backend/rnn/decoders.py 93.92% <0.00%> (+1.04%) ⬆️
espnet/nets/pytorch_backend/lm/default.py 93.86% <0.00%> (+1.22%) ⬆️
espnet2/samplers/num_elements_batch_sampler.py 87.50% <0.00%> (+1.25%) ⬆️
... and 108 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wanchichen
Copy link
Contributor

tools/installers/install_datasets.sh seems to be empty.
Is it OK?

@sw005320 It must be OK.

Basically @wanchichen added install_datasets.sh in 8757bf6, but did not turned on the executable bit on the script file. For this reason, the following command did not work previously:

Error: it seems that datasets is not installed.
Error: please install datasets as follows.
Error: cd ${MAIN_ROOT}/tools/installers && ./install_datasets.sh

So I did chmod +x install_datasets.sh as part of this PR (so that users actually can execute ./install_datasets.sh). This is why Git shows an "empty" diff.

Thanks for the fix! Not sure how that happened.

@mergify mergify bot merged commit bc4b524 into espnet:master Feb 1, 2023
@fujimotos fujimotos deleted the sf/reazonspeech branch February 1, 2023 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASR Automatic speech recogntion auto-merge Enable auto-merge ESPnet2 Installation README Recipe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants