single language track setups #4895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 30, 2023 11:47
ftshijt
reviewed
Jan 31, 2023
There was a problem hiding this comment.
Looks good to me. Please follow our discussion and fix the CI issues. Let's accelerate the process~ Thanks @DanBerrebbi
Codecov Report
@@ Coverage Diff @@
## master #4895 +/- ##
==========================================
+ Coverage 73.10% 76.58% +3.48%
==========================================
Files 603 603
Lines 53709 53737 +28
==========================================
+ Hits 39264 41155 +1891
+ Misses 14445 12582 -1863
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Many thanks! Looks great to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed some single language langs :
I removed pol because similar to rus and nob because similar to swe,
I added French because there was no roman language(french, spanish, italian, portuguese ...) and added Swahili because there was no African language.
For dataset selections, it is summarized on the last page of https://docs.google.com/document/d/1sb8SyDjcMf7FDiZHH8wVcZ0EADtXdNBF3LpA9Cu0I1k/edit
For test sets format, I think that it is good to keep only one test set per language with all the datasets of this lang. This way it is an easy decoding process and then WE can split it the decoded file to have scores per dataset and so compute metrics for domain shifts ... . So we have flexibility for scoring and the user has a simple process.
Points to be discussed :