Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardized inference and number of iterations for mSuperb single lang track #4905

Merged
merged 7 commits into from Feb 3, 2023

Conversation

DanBerrebbi
Copy link
Contributor

No description provided.

@mergify mergify bot added the ESPnet2 label Feb 1, 2023
@ftshijt ftshijt added the Recipe label Feb 2, 2023
@ftshijt
Copy link
Collaborator

ftshijt commented Feb 2, 2023

I think you also need some updates to some other scripts (due to the version change)

@DanBerrebbi
Copy link
Contributor Author

Yes I saw it
I'll update after I make sure the current files work well without any bug which I am doing now

@mergify mergify bot added the ESPnet1 label Feb 3, 2023
@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #4905 (75bc56e) into master (e753fa3) will increase coverage by 0.00%.
The diff coverage is 77.77%.

@@           Coverage Diff           @@
##           master    #4905   +/-   ##
=======================================
  Coverage   76.57%   76.58%           
=======================================
  Files         603      603           
  Lines       53737    53730    -7     
=======================================
  Hits        41148    41148           
+ Misses      12589    12582    -7     
Flag Coverage Δ
test_integration_espnet1 66.33% <100.00%> (+0.13%) ⬆️
test_integration_espnet2 47.59% <80.00%> (-0.02%) ⬇️
test_python 66.46% <44.44%> (+<0.01%) ⬆️
test_utils 23.35% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
espnet/nets/pytorch_backend/rnn/decoders.py 93.92% <ø> (ø)
espnet2/asr/decoder/rnn_decoder.py 73.64% <ø> (ø)
espnet2/asr/encoder/hubert_encoder.py 51.44% <ø> (ø)
espnet2/asr/frontend/fused.py 93.10% <ø> (ø)
espnet2/asr/pit_espnet_model.py 90.26% <ø> (ø)
espnet2/asr/state_spaces/base.py 63.63% <ø> (ø)
espnet2/asr/state_spaces/s4.py 53.00% <ø> (ø)
espnet2/bin/asr_inference.py 84.13% <ø> (ø)
espnet2/bin/diar_inference.py 80.81% <0.00%> (ø)
espnet2/diar/layers/abs_mask.py 100.00% <ø> (ø)
... and 35 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@ftshijt ftshijt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! thanks

@ftshijt ftshijt merged commit 86bba83 into espnet:master Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants