Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in gen_task1_data.sh from CHiME7 #4953

Merged
merged 2 commits into from Mar 21, 2023
Merged

Conversation

boeddeker
Copy link
Contributor

I got the error:

local/gen_task1_data.sh: line 36: [-d: command not found

and PyCharm complained:

Couldn't parse this test expression. Fix to allow more checks.
See SC1073.
You need a space after the [ and before the ].
See SC1035.

I think someone forgot to add whitespaces, otherwise it is not valid bash code.

@mergify mergify bot added the ESPnet2 label Feb 21, 2023
@sw005320 sw005320 added this to the v.202303 milestone Feb 21, 2023
@sw005320 sw005320 added Recipe ASR Automatic speech recogntion labels Mar 21, 2023
@sw005320
Copy link
Contributor

@popcornell, is it already considered in your PR, or should I merge it?

@popcornell
Copy link
Contributor

You should merge it. Somehow I did not get this error on my side, and I like rerun this bit like 10 times.
It is indeed wrong but maybe more recent bash versions are able to parse it ?

@sw005320
Copy link
Contributor

OK, thanks!

@sw005320 sw005320 merged commit 0b24151 into espnet:master Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASR Automatic speech recogntion Bugfix ESPnet2 Recipe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants