Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test #4984

Closed
wants to merge 1 commit into from
Closed

test #4984

wants to merge 1 commit into from

Conversation

kamo-naoyuki
Copy link
Collaborator

No description provided.

@mergify mergify bot added the ESPnet2 label Mar 6, 2023
@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Merging #4984 (c1f2a85) into master (b5b2b11) will decrease coverage by 3.42%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4984      +/-   ##
==========================================
- Coverage   76.91%   73.49%   -3.42%     
==========================================
  Files         606      606              
  Lines       53770    53770              
==========================================
- Hits        41355    39518    -1837     
- Misses      12415    14252    +1837     
Flag Coverage Δ
test_integration_espnet1 66.33% <ø> (ø)
test_integration_espnet2 ?
test_python 66.85% <ø> (ø)
test_utils 23.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
espnet2/train/abs_gan_espnet_model.py 0.00% <0.00%> (-100.00%) ⬇️
espnet2/bin/st_inference_streaming.py 0.00% <0.00%> (-86.15%) ⬇️
espnet2/tasks/gan_tts.py 0.00% <0.00%> (-79.36%) ⬇️
espnet2/gan_tts/espnet_model.py 0.00% <0.00%> (-76.93%) ⬇️
espnet2/train/gan_trainer.py 0.00% <0.00%> (-69.59%) ⬇️
espnet2/lm/espnet_model.py 30.76% <0.00%> (-69.24%) ⬇️
espnet2/bin/gan_tts_train.py 0.00% <0.00%> (-66.67%) ⬇️
espnet2/main_funcs/collect_stats.py 25.00% <0.00%> (-65.63%) ⬇️
espnet2/fst/lm_rescore.py 12.16% <0.00%> (-58.11%) ⬇️
espnet2/bin/aggregate_stats_dirs.py 33.33% <0.00%> (-52.64%) ⬇️
... and 44 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kamo-naoyuki
Copy link
Collaborator Author

Would you happen to have any idea about this error?

https://github.com/espnet/espnet/actions/runs/4340074973/jobs/7578272513#step:18:2537

This error may happen only for enh tse task.

@ShigekiKarita

@ShigekiKarita
Copy link
Member

hmm no idea. Perhaps, multiple processes can write .coverage at the same time?

@kamo-naoyuki
Copy link
Collaborator Author

Thanks, Shigeki. Could you tell me how we generate .coverage in CI? I don't understand the setting basically.

@kamo-naoyuki
Copy link
Collaborator Author

Is the following command generating the .converage, right?

python="coverage run --append"

@kamo-naoyuki
Copy link
Collaborator Author

I tested running utils/run.pl JOB=1:10 JOB.log coverage run --append empty.py.

I couldn't reproduce Couldn't use data file '.../.coverage': no such table: meta, but it is sometimes successful, and sometimes is failed with sqlite3.OperationalError: no such table: coverage_schema or Couldn't use data file '.../.coverage': no such table: coverage_schema
Potentially, parallel running for coverage run --append causes the problems.

I'm not sure these errors come from the same reason, but I found that once .coverage was generated successfully, I didn't get the error after it.

I'll try to modify the script to generate .coverage at the first in a single process.

@kamo-naoyuki kamo-naoyuki mentioned this pull request Mar 6, 2023
@kamo-naoyuki kamo-naoyuki deleted the kamo-naoyuki-patch-1 branch March 6, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants