Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add InterCTC to E-Branchformer encoder, and the ability to save InterCTC inference output to files #5084
Add InterCTC to E-Branchformer encoder, and the ability to save InterCTC inference output to files #5084
Changes from 4 commits
ee0daae
e05ddc9
c0bf024
a55e469
6b33255
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 442 in espnet2/asr/encoder/e_branchformer_encoder.py
Codecov / codecov/patch
espnet2/asr/encoder/e_branchformer_encoder.py#L439-L442
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intermediate CTC only supports greedy decoding? I think it's fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I think greedy decoding can probably cover most use cases
Check warning on line 727 in espnet2/bin/asr_inference.py
Codecov / codecov/patch
espnet2/bin/asr_inference.py#L727
Check warning on line 748 in espnet2/bin/asr_inference.py
Codecov / codecov/patch
espnet2/bin/asr_inference.py#L747-L748