Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SVS] Update XiaoiceSing #5124

Merged
merged 19 commits into from Apr 23, 2023
Merged

[SVS] Update XiaoiceSing #5124

merged 19 commits into from Apr 23, 2023

Conversation

A-Quarter-Mile
Copy link
Contributor

@A-Quarter-Mile A-Quarter-Mile commented Apr 17, 2023

Hi @ftshijt, here are updates on Muskits:

  • Add slur in svs
  • Add pitch_loss and vuv_loss for XiaoiceSing following XiaoiceSing2.

@mergify mergify bot added the ESPnet2 label Apr 17, 2023
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #5124 (9b23beb) into master (fc37f80) will decrease coverage by 0.12%.
The diff coverage is 8.84%.

@@            Coverage Diff             @@
##           master    #5124      +/-   ##
==========================================
- Coverage   75.10%   74.98%   -0.12%     
==========================================
  Files         616      617       +1     
  Lines       55051    55176     +125     
==========================================
+ Hits        41348    41376      +28     
- Misses      13703    13800      +97     
Flag Coverage Δ
test_integration_espnet1 66.28% <ø> (ø)
test_integration_espnet2 47.75% <0.00%> (-0.02%) ⬇️
test_python 65.37% <8.84%> (-0.10%) ⬇️
test_utils 23.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
espnet2/bin/svs_inference.py 0.00% <0.00%> (ø)
espnet2/gan_svs/espnet_model.py 0.00% <0.00%> (ø)
espnet2/gan_svs/joint/joint_score2wav.py 19.44% <ø> (ø)
espnet2/gan_svs/vits/vits.py 91.61% <ø> (ø)
espnet2/svs/espnet_model.py 7.56% <0.00%> (-0.25%) ⬇️
espnet2/svs/naive_rnn/naive_rnn.py 11.69% <ø> (ø)
espnet2/svs/naive_rnn/naive_rnn_dp.py 10.92% <ø> (ø)
espnet2/train/preprocessor.py 29.09% <0.00%> (-0.29%) ⬇️
espnet2/svs/xiaoice/XiaoiceSing.py 10.77% <2.56%> (-1.17%) ⬇️
espnet2/svs/xiaoice/loss.py 16.66% <16.66%> (ø)

... and 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@A-Quarter-Mile A-Quarter-Mile changed the title [SVS] Add slur [SVS] Update XiaoiceSing Apr 20, 2023
Copy link
Collaborator

@ftshijt ftshijt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! please check the vuv part to make sure it is correct

@ftshijt ftshijt merged commit f14e4d0 into espnet:master Apr 23, 2023
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants