Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix format_wav_scp.py #5150

Merged
merged 2 commits into from Apr 28, 2023
Merged

fix format_wav_scp.py #5150

merged 2 commits into from Apr 28, 2023

Conversation

kamo-naoyuki
Copy link
Collaborator

The processing for cache has a bug.

@kamo-naoyuki kamo-naoyuki added auto-merge Enable auto-merge Bugfix labels Apr 28, 2023
@mergify mergify bot added the ESPnet2 label Apr 28, 2023
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #5150 (3a37786) into master (866c801) will increase coverage by 0.00%.
The diff coverage is 70.00%.

@@           Coverage Diff            @@
##           master    #5150    +/-   ##
========================================
  Coverage   74.98%   74.99%            
========================================
  Files         617      618     +1     
  Lines       55176    55585   +409     
========================================
+ Hits        41376    41686   +310     
- Misses      13800    13899    +99     
Flag Coverage Δ
test_integration_espnet1 66.28% <ø> (-0.01%) ⬇️
test_integration_espnet2 47.61% <70.00%> (-0.15%) ⬇️
test_python 65.45% <70.00%> (+0.07%) ⬆️
test_utils 23.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
espnet2/fileio/sound_scp.py 97.50% <70.00%> (-1.63%) ⬇️

... and 21 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kamo-naoyuki kamo-naoyuki force-pushed the fix_format_wav branch 3 times, most recently from 78c545b to c2f9188 Compare April 28, 2023 11:12
@mergify mergify bot merged commit badae0c into espnet:master Apr 28, 2023
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant