Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SVS] Add new recipes #5158

Merged
merged 13 commits into from May 12, 2023
Merged

[SVS] Add new recipes #5158

merged 13 commits into from May 12, 2023

Conversation

A-Quarter-Mile
Copy link
Contributor

@A-Quarter-Mile A-Quarter-Mile commented May 5, 2023

Hi @ftshijt, here are new updates on Muskits-ESPnet:

  • Add M4Singer recipe (multi singer)
  • Add oniku recipe
  • Add pjs recipe

@mergify mergify bot added the ESPnet2 label May 5, 2023
Comment on lines +16 to +34
"Alto-1",
"Alto-2",
"Alto-3",
"Alto-4",
"Alto-5",
"Alto-6",
"Bass-1",
"Bass-2",
"Bass-3",
"Soprano-1",
"Soprano-2",
"Soprano-3",
"Soprano-4",
"Tenor-1",
"Tenor-2",
"Tenor-3",
"Tenor-4",
"Tenor-5",
"Tenor-6",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you verify that the selected singer is the official test set?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the singers in M4Singer. We can choose singers from this list according to different condition. And it seems that there is no official split for test set.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good

@ftshijt
Copy link
Collaborator

ftshijt commented May 11, 2023

Could you please also add entries to the egs2/README.md?

@mergify mergify bot added the README label May 11, 2023
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #5158 (33456aa) into master (4430286) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5158   +/-   ##
=======================================
  Coverage   74.99%   74.99%           
=======================================
  Files         618      618           
  Lines       55588    55588           
=======================================
  Hits        41689    41689           
  Misses      13899    13899           
Flag Coverage Δ
test_integration_espnet1 66.28% <ø> (ø)
test_integration_espnet2 47.61% <0.00%> (ø)
test_python 65.45% <100.00%> (ø)
test_utils 23.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
espnet2/fileio/score_scp.py 60.62% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ftshijt
Copy link
Collaborator

ftshijt commented May 12, 2023

Thanks for your contribution!

@ftshijt ftshijt merged commit 98dc240 into espnet:master May 12, 2023
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants