Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KSC recipe #5171

Merged
merged 21 commits into from May 19, 2023
Merged

KSC recipe #5171

merged 21 commits into from May 19, 2023

Conversation

khassanoff
Copy link
Contributor

Hello,

I would like to contribute an ESPnet2 recipe for Kazakh Speech Corpus (KSC). KSC contains around 300 hours of manually transcribed speech data of Kazakh language dedicated to ASR task. The dataset is publicly available and is present in OpenSLR website.

Please let me know if any other changes are required.

Thank you!

Regards,
Yerbolat Khassanov

@khassanoff khassanoff changed the title Ksc recipe KSC recipe May 17, 2023
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #5171 (30bebc3) into master (6e35c14) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5171   +/-   ##
=======================================
  Coverage   74.99%   74.99%           
=======================================
  Files         618      618           
  Lines       55603    55603           
=======================================
  Hits        41700    41700           
  Misses      13903    13903           
Flag Coverage Δ
test_integration_espnet1 66.28% <ø> (+<0.01%) ⬆️
test_integration_espnet2 47.61% <ø> (ø)
test_python 65.45% <ø> (ø)
test_utils 23.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sw005320 sw005320 requested a review from ftshijt May 17, 2023 11:15
@sw005320 sw005320 added Recipe ASR Automatic speech recogntion labels May 17, 2023
@sw005320
Copy link
Contributor

Thanks a lot, @khassanoff

@ftshijt, can you review the PR?

@sw005320 sw005320 added this to the v.202307 milestone May 18, 2023
@sw005320
Copy link
Contributor

I quickly reviewed it.
It looks very good to me.
Can you upload a model to the Hugging Face hub and put a link to egs2/ksc/asr1/RESULTS.md?
(check https://github.com/espnet/espnet/blob/master/CONTRIBUTING.md#132-espnet2-recipes)

Copy link
Collaborator

@ftshijt ftshijt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty cool! Many thanks to your contribution.

egs2/ksc/asr1/local/prepare_data.sh Outdated Show resolved Hide resolved
egs2/ksc/asr1/run.sh Outdated Show resolved Hide resolved
egs2/ksc/asr1/run.sh Show resolved Hide resolved
egs2/ksc/asr1/run.sh Outdated Show resolved Hide resolved
egs2/ksc/asr1/run.sh Outdated Show resolved Hide resolved
egs2/ksc/asr1/local/prepare_data.sh Outdated Show resolved Hide resolved
egs2/ksc/asr1/local/prepare_data.sh Outdated Show resolved Hide resolved
khassanoff and others added 6 commits May 19, 2023 09:32
Co-authored-by: Jiatong <728307998@qq.com>
Co-authored-by: Jiatong <728307998@qq.com>
Co-authored-by: Jiatong <728307998@qq.com>
Co-authored-by: Jiatong <728307998@qq.com>
Co-authored-by: Jiatong <728307998@qq.com>
@khassanoff
Copy link
Contributor Author

All suggested changes have been applied, please take a look and let me know if I miss something. Thanks!

Copy link
Contributor

@sw005320 sw005320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!
Thanks a lot!

@sw005320 sw005320 added the auto-merge Enable auto-merge label May 19, 2023
@mergify mergify bot merged commit 0e7146e into espnet:master May 19, 2023
24 of 25 checks passed
@khassanoff khassanoff deleted the ksc_recipe branch May 19, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASR Automatic speech recogntion auto-merge Enable auto-merge ESPnet2 README Recipe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants