Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SVS README.md #5180

Merged
merged 3 commits into from May 24, 2023
Merged

Update SVS README.md #5180

merged 3 commits into from May 24, 2023

Conversation

jerryuhoo
Copy link
Contributor

This VISinger setting is based on OpenCPop, maybe we should make the same modifications to the settings of Ofuton as well.

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #5180 (fb881e5) into master (d26489e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5180   +/-   ##
=======================================
  Coverage   75.00%   75.00%           
=======================================
  Files         630      630           
  Lines       56821    56821           
=======================================
  Hits        42619    42619           
  Misses      14202    14202           
Flag Coverage Δ
test_integration_espnet1 66.28% <ø> (ø)
test_integration_espnet2 47.61% <ø> (ø)
test_python 65.67% <ø> (ø)
test_utils 23.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@ftshijt ftshijt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Can you also update the readme in https://github.com/espnet/espnet#svs-singing-voice-synthesis ?

egs2/TEMPLATE/svs1/README.md Outdated Show resolved Hide resolved
egs2/TEMPLATE/svs1/README.md Outdated Show resolved Hide resolved
egs2/TEMPLATE/svs1/README.md Outdated Show resolved Hide resolved
@ftshijt ftshijt added the Music Music processing label May 23, 2023
@ftshijt ftshijt added the auto-merge Enable auto-merge label May 23, 2023
@mergify mergify bot merged commit e272901 into espnet:master May 24, 2023
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Enable auto-merge ESPnet2 Music Music processing README
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants