Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2022fall new task tutorial #5186

Merged
merged 11 commits into from May 26, 2023
Merged

2022fall new task tutorial #5186

merged 11 commits into from May 26, 2023

Conversation

ftshijt
Copy link
Collaborator

@ftshijt ftshijt commented May 25, 2023

For the new task tutorial update, the code is in general not complete for tutorial purpose only.

@mergify mergify bot added the ESPnet2 label May 25, 2023
@sw005320 sw005320 added this to the v.202307 milestone May 25, 2023
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #5186 (35f80b5) into master (52e929b) will decrease coverage by 2.08%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #5186      +/-   ##
==========================================
- Coverage   76.57%   74.49%   -2.08%     
==========================================
  Files         603      640      +37     
  Lines       53730    57209    +3479     
==========================================
+ Hits        41144    42619    +1475     
- Misses      12586    14590    +2004     
Flag Coverage Δ
test_integration_espnet1 66.28% <ø> (-0.05%) ⬇️
test_integration_espnet2 47.61% <ø> (+0.03%) ⬆️
test_python 65.22% <0.00%> (-1.24%) ⬇️
test_utils 23.28% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
espnet2/asvspoof/decoder/abs_decoder.py 0.00% <0.00%> (ø)
espnet2/asvspoof/decoder/linear_decoder.py 0.00% <0.00%> (ø)
espnet2/asvspoof/espnet_model.py 0.00% <0.00%> (ø)
espnet2/asvspoof/loss/abs_loss.py 0.00% <0.00%> (ø)
espnet2/asvspoof/loss/am_softmax_loss.py 0.00% <0.00%> (ø)
espnet2/asvspoof/loss/binary_loss.py 0.00% <0.00%> (ø)
espnet2/asvspoof/loss/oc_softmax_loss.py 0.00% <0.00%> (ø)
espnet2/bin/asvspoof_inference.py 0.00% <0.00%> (ø)
espnet2/bin/asvspoof_train.py 0.00% <0.00%> (ø)
espnet2/tasks/asvspoof.py 0.00% <0.00%> (ø)

... and 146 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ftshijt
Copy link
Collaborator Author

ftshijt commented May 25, 2023

It is generally not possible to add CI test for this PR cause we leave blanks in many essential parts. Can we merge it without adding tests? @sw005320

@ftshijt ftshijt merged commit 165b61e into master May 26, 2023
24 of 26 checks passed
@ftshijt ftshijt deleted the 2022fall_new_task_tutorial branch May 26, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants