Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SVS] Updates for recipes #5187

Merged
merged 37 commits into from May 26, 2023
Merged

[SVS] Updates for recipes #5187

merged 37 commits into from May 26, 2023

Conversation

A-Quarter-Mile
Copy link
Contributor

Hi @ftshijt, here are updates on Muskit.

  • Add new recipe Natsume for SVS.
  • Add MIDI_reader in fileio/.
  • Provide instructions on score preparation for new recipe in ReadMe.md. The details can be found in the comments of codes. Case 2 is left to be updated.

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #5187 (c445c5c) into master (f4d7fea) will increase coverage by 0.03%.
The diff coverage is 63.15%.

@@            Coverage Diff             @@
##           master    #5187      +/-   ##
==========================================
+ Coverage   75.00%   75.04%   +0.03%     
==========================================
  Files         630      630              
  Lines       56821    56872      +51     
==========================================
+ Hits        42619    42679      +60     
+ Misses      14202    14193       -9     
Flag Coverage Δ
test_integration_espnet1 66.28% <ø> (ø)
test_integration_espnet2 47.58% <24.39%> (-0.03%) ⬇️
test_python 65.71% <63.15%> (+0.04%) ⬆️
test_utils 23.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
espnet2/svs/espnet_model.py 6.78% <0.00%> (-0.23%) ⬇️
espnet2/tasks/svs.py 46.47% <28.57%> (-0.49%) ⬇️
espnet2/fileio/score_scp.py 66.66% <82.92%> (+6.04%) ⬆️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot added the Installation label May 25, 2023
egs2/TEMPLATE/svs1/README.md Outdated Show resolved Hide resolved
egs2/TEMPLATE/svs1/README.md Outdated Show resolved Hide resolved
egs2/TEMPLATE/svs1/README.md Outdated Show resolved Hide resolved
egs2/TEMPLATE/svs1/README.md Outdated Show resolved Hide resolved
egs2/TEMPLATE/svs1/README.md Outdated Show resolved Hide resolved
egs2/TEMPLATE/svs1/README.md Show resolved Hide resolved
egs2/TEMPLATE/svs1/README.md Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@ftshijt ftshijt added the Music Music processing label May 25, 2023
A-Quarter-Mile and others added 8 commits May 26, 2023 10:15
Co-authored-by: Jiatong <728307998@qq.com>
Co-authored-by: Jiatong <728307998@qq.com>
Co-authored-by: Jiatong <728307998@qq.com>
Co-authored-by: Jiatong <728307998@qq.com>
Co-authored-by: Jiatong <728307998@qq.com>
Add examples of different lyric-phoneme pairs
@mergify mergify bot added the CI Travis, Circle CI, etc label May 26, 2023
@ftshijt
Copy link
Collaborator

ftshijt commented May 26, 2023

Many thanks for the update! I will merge it after verifying the CI has passed.

@ftshijt
Copy link
Collaborator

ftshijt commented May 26, 2023

Many thanks for your contribution!

@ftshijt ftshijt merged commit 13b986c into espnet:master May 26, 2023
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Travis, Circle CI, etc ESPnet2 Installation Music Music processing README
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants