Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when score_type is set to normal in ml_superb #5217

Merged
merged 2 commits into from Jun 6, 2023

Conversation

ftshijt
Copy link
Collaborator

@ftshijt ftshijt commented Jun 6, 2023

Some participants found that when the score_type is set as normal the scoring might be crashed because of not downloading the language tree files.

@mergify mergify bot added the ESPnet2 label Jun 6, 2023
@ftshijt ftshijt added Bugfix Recipe ASR Automatic speech recogntion labels Jun 6, 2023
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #5217 (7f43e50) into master (a631428) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5217   +/-   ##
=======================================
  Coverage   74.54%   74.54%           
=======================================
  Files         640      640           
  Lines       57267    57267           
=======================================
  Hits        42688    42688           
  Misses      14579    14579           
Flag Coverage Δ
test_integration_espnet1 66.28% <ø> (ø)
test_integration_espnet2 47.58% <ø> (ø)
test_python 65.28% <ø> (ø)
test_utils 23.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ftshijt ftshijt merged commit 0216f85 into espnet:master Jun 6, 2023
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASR Automatic speech recogntion Bugfix ESPnet2 Recipe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant