Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update import order #5229

Merged
merged 2 commits into from Jun 14, 2023
Merged

Update import order #5229

merged 2 commits into from Jun 14, 2023

Conversation

ftshijt
Copy link
Collaborator

@ftshijt ftshijt commented Jun 14, 2023

To fix a potential issue when speechbrain is not installed but want to use RawNet speaker embedding extraction

@ftshijt ftshijt requested a review from Fhrozen June 14, 2023 17:02
@mergify mergify bot added the ESPnet2 label Jun 14, 2023
@ftshijt ftshijt added this to the v.202307 milestone Jun 14, 2023
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #5229 (03d8447) into master (096e2bb) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5229      +/-   ##
==========================================
- Coverage   74.43%   74.43%   -0.01%     
==========================================
  Files         642      642              
  Lines       57611    57611              
==========================================
- Hits        42885    42884       -1     
- Misses      14726    14727       +1     
Flag Coverage Δ
test_integration_espnet1 66.28% <ø> (ø)
test_integration_espnet2 47.52% <ø> (ø)
test_python 65.14% <ø> (-0.01%) ⬇️
test_utils 23.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sw005320 sw005320 merged commit 43a56f9 into master Jun 14, 2023
25 of 26 checks passed
@sw005320 sw005320 deleted the ftshijt-patch-1 branch June 14, 2023 20:10
@sw005320
Copy link
Contributor

Thanks, @ftshijt!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants