Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate recipe for nit_song070 from Muskit #5251

Merged
merged 35 commits into from Jul 21, 2023
Merged

Conversation

wwwbxy123
Copy link
Contributor

@wwwbxy123 wwwbxy123 commented Jun 23, 2023

The recipe from Muskit: https://github.com/SJTMusicTeam/Muskits/tree/main/egs/nit_song070/svs1

Similar to opencpop recipe. The difference is making segments in wav, label text and and score.

Successfully started training step.

@mergify mergify bot added the ESPnet2 label Jun 23, 2023
@ftshijt
Copy link
Collaborator

ftshijt commented Jun 23, 2023

Thanks! @A-Quarter-Mile could you help with @wwwbxy123 's recipe formulation?

Can you also at the same time, fix the issue in CI? https://github.com/espnet/espnet/actions/runs/5352866393/jobs/9708205475?pr=5251#step:7:465

@ftshijt ftshijt added Recipe Music Music processing labels Jun 23, 2023
@ftshijt ftshijt added this to the v.202307 milestone Jun 23, 2023
@wwwbxy123
Copy link
Contributor Author

Thanks! @A-Quarter-Mile could you help with @wwwbxy123 's recipe formulation?

Can you also at the same time, fix the issue in CI? https://github.com/espnet/espnet/actions/runs/5352866393/jobs/9708205475?pr=5251#step:7:465

Done.

@wwwbxy123 wwwbxy123 changed the title Nit song receipe Migrate receipe for nit_song070 from Muskit Jun 30, 2023
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #5251 (641d6ca) into master (f122c22) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5251   +/-   ##
=======================================
  Coverage   76.10%   76.10%           
=======================================
  Files         658      658           
  Lines       59156    59156           
=======================================
  Hits        45022    45022           
  Misses      14134    14134           
Flag Coverage Δ
test_integration_espnet1 65.96% <ø> (ø)
test_integration_espnet2 47.52% <ø> (ø)
test_python 66.49% <ø> (ø)
test_utils 23.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

.gitignore Outdated Show resolved Hide resolved
@A-Quarter-Mile
Copy link
Contributor

Thanks for your contributions! The above are minor changes.

wwwbxy123 and others added 3 commits July 8, 2023 00:02
Co-authored-by: Yuning Wu <38801033+A-Quarter-Mile@users.noreply.github.com>
Co-authored-by: Yuning Wu <38801033+A-Quarter-Mile@users.noreply.github.com>
@ftshijt
Copy link
Collaborator

ftshijt commented Jul 11, 2023

It looks ready to merge. Since the CI is recently blocking, we will wait a bit more time for it to be fixed. Thanks for your effort and contribution!

@mergify mergify bot added the README label Jul 13, 2023
@ftshijt ftshijt added the auto-merge Enable auto-merge label Jul 20, 2023
@mergify mergify bot merged commit 0971f17 into espnet:master Jul 21, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Enable auto-merge ESPnet2 Music Music processing README Recipe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants