Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MFA format fix #5275

Merged
merged 3 commits into from Jul 24, 2023
Merged

MFA format fix #5275

merged 3 commits into from Jul 24, 2023

Conversation

iamanigeeit
Copy link
Contributor

The key changes in this fix are to treat apostrophes as word characters, and remove braces from transcripts. Both were causing mfa_format.py to fail on the LibriTTS corpus.

Other changes are for readability.

(cherry picked from commit 92aa7f23fd90518407c633dfd4f2ac947dafb477)
@mergify mergify bot added the ESPnet2 label Jul 3, 2023
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #5275 (93b136a) into master (c9cd4de) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5275   +/-   ##
=======================================
  Coverage   76.11%   76.11%           
=======================================
  Files         672      672           
  Lines       59864    59864           
=======================================
  Hits        45567    45567           
  Misses      14297    14297           
Flag Coverage Δ
test_configuration_espnet2 ∅ <ø> (∅)
test_integration_espnet1 65.93% <ø> (ø)
test_integration_espnet2 47.92% <ø> (ø)
test_python_espnet1 20.50% <ø> (ø)
test_python_espnet2 51.35% <ø> (ø)
test_utils 23.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kan-bayashi kan-bayashi added Bugfix TTS Text-to-speech auto-merge Enable auto-merge labels Jul 24, 2023
@mergify mergify bot merged commit 4847b5f into espnet:master Jul 24, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Enable auto-merge Bugfix ESPnet2 TTS Text-to-speech
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants