Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a data preparation issue for librimix recipe. #5322

Merged
merged 1 commit into from Jul 21, 2023

Conversation

LiChenda
Copy link
Contributor

In egs2/librimix/asr1/local/data.sh, L116, if mix_f matches multiple files, the grep command (in some version) will output the specific matched file name (which is not the expected output) and lead to a wrong utt_id in data preparation.

So I updated the data preparation scripts to avoid this issue.

@mergify mergify bot added the ESPnet2 label Jul 21, 2023
@sw005320 sw005320 added Recipe ASR Automatic speech recogntion labels Jul 21, 2023
@sw005320 sw005320 added this to the v.202307 milestone Jul 21, 2023
@sw005320 sw005320 added the auto-merge Enable auto-merge label Jul 21, 2023
@sw005320
Copy link
Contributor

Thanks, @LiChenda!

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #5322 (394a27e) into master (17b472d) will increase coverage by 3.58%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5322      +/-   ##
==========================================
+ Coverage   72.52%   76.10%   +3.58%     
==========================================
  Files         658      658              
  Lines       59156    59156              
==========================================
+ Hits        42902    45022    +2120     
+ Misses      16254    14134    -2120     
Flag Coverage Δ
test_integration_espnet1 65.96% <ø> (ø)
test_integration_espnet2 47.52% <ø> (?)
test_python 66.49% <ø> (ø)
test_utils 23.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 63 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot merged commit ebfc132 into espnet:master Jul 21, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASR Automatic speech recogntion auto-merge Enable auto-merge ESPnet2 Recipe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants