Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused file + small typo/style #5346

Merged
merged 2 commits into from Jul 25, 2023
Merged

remove unused file + small typo/style #5346

merged 2 commits into from Jul 25, 2023

Conversation

b-flo
Copy link
Member

@b-flo b-flo commented Jul 22, 2023

What?

  • Remove normalization.py from asr_transducer/encoder/modules/
  • Change asr_transducer/encoder/building.py docstring

Why?

  • File is unused. It was moved to asr_transducer/encoder/ after a refactor but old file was not removed.
  • Typos and style issue.

See also

Related to #5140

@b-flo b-flo added this to the v.202307 milestone Jul 22, 2023
@mergify mergify bot added the ESPnet2 label Jul 22, 2023
@b-flo b-flo added Refactoring Refactoring RNNT (RNN) transducer related issue ESPnet2 and removed ESPnet2 labels Jul 22, 2023
@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Merging #5346 (05c5bc0) into master (47f989a) will decrease coverage by 6.31%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5346      +/-   ##
==========================================
- Coverage   76.59%   70.29%   -6.31%     
==========================================
  Files         672      670       -2     
  Lines       59912    59786     -126     
==========================================
- Hits        45892    42024    -3868     
- Misses      14020    17762    +3742     
Flag Coverage Δ
test_configuration_espnet2 ∅ <ø> (∅)
test_integration_espnet1 65.95% <ø> (+0.02%) ⬆️
test_integration_espnet2 49.24% <ø> (ø)
test_python_espnet1 ?
test_python_espnet2 51.30% <ø> (-0.01%) ⬇️
test_utils 23.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
espnet2/asr_transducer/encoder/building.py 100.00% <ø> (ø)

... and 116 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@b-flo b-flo merged commit 077497c into espnet:master Jul 25, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ESPnet2 Refactoring Refactoring RNNT (RNN) transducer related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants