Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couple of tweaks for asr2.sh for the HF hub upload #5362

Merged
merged 1 commit into from Jul 23, 2023

Conversation

akreal
Copy link
Contributor

@akreal akreal commented Jul 23, 2023

What?

  • Set the lang variable
  • Enable LFS tracking for *.mdl files

Why?

  • I think setting the language variable is needed (HF hub complains when language is set to noinfo).
  • I'm not sure if setting the LFS tracking for *.mdl files is needed. Does it work without it for everyone else? I have not investigated what is the expected behaviour here, but in my environment HF hub complained that *.mdl is not under LFS.

@mergify mergify bot added the ESPnet2 label Jul 23, 2023
@codecov
Copy link

codecov bot commented Jul 23, 2023

Codecov Report

Merging #5362 (a00b287) into master (890ba71) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5362   +/-   ##
=======================================
  Coverage   76.11%   76.11%           
=======================================
  Files         672      672           
  Lines       59859    59859           
=======================================
  Hits        45563    45563           
  Misses      14296    14296           
Flag Coverage Δ
test_configuration_espnet2 ∅ <ø> (∅)
test_integration_espnet1 65.93% <ø> (ø)
test_integration_espnet2 47.92% <ø> (ø)
test_python_espnet1 20.51% <ø> (ø)
test_python_espnet2 51.35% <ø> (ø)
test_utils 23.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sw005320 sw005320 requested a review from simpleoier July 23, 2023 11:39
@sw005320 sw005320 added this to the v.202307 milestone Jul 23, 2023
@sw005320 sw005320 added Recipe ASR Automatic speech recogntion labels Jul 23, 2023
Copy link
Collaborator

@simpleoier simpleoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This modification is very necessary.

@sw005320 sw005320 merged commit 49ba1b1 into espnet:master Jul 23, 2023
26 checks passed
@sw005320
Copy link
Contributor

Thanks a lot!

@akreal akreal deleted the patch-2 branch October 12, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASR Automatic speech recogntion ESPnet2 Recipe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants