Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in ngram training in slu.sh #5364

Merged
merged 1 commit into from Jul 23, 2023
Merged

Conversation

siddhu001
Copy link
Collaborator

What?

Made minor fix in slu.sh

Why?

There was bug in ngram training code in slu.sh that used only first token instead of all tokens in transcripts.

See also

Refer #5312

@mergify mergify bot added the ESPnet2 label Jul 23, 2023
@codecov
Copy link

codecov bot commented Jul 23, 2023

Codecov Report

Merging #5364 (79f5cc0) into master (42f3182) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5364      +/-   ##
==========================================
- Coverage   76.11%   76.11%   -0.01%     
==========================================
  Files         672      672              
  Lines       59859    59859              
==========================================
- Hits        45563    45561       -2     
- Misses      14296    14298       +2     
Flag Coverage Δ
test_configuration_espnet2 ∅ <ø> (∅)
test_integration_espnet1 65.93% <ø> (ø)
test_integration_espnet2 47.91% <ø> (-0.01%) ⬇️
test_python_espnet1 20.51% <ø> (ø)
test_python_espnet2 51.35% <ø> (ø)
test_utils 23.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sw005320 sw005320 added this to the v.202307 milestone Jul 23, 2023
@sw005320 sw005320 linked an issue Jul 23, 2023 that may be closed by this pull request
@sw005320 sw005320 added SLU Spoken language understanding Bugfix auto-merge Enable auto-merge labels Jul 23, 2023
@mergify mergify bot merged commit 479b8d4 into espnet:master Jul 23, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Enable auto-merge Bugfix ESPnet2 SLU Spoken language understanding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug report: Ngram training in SLU
2 participants