Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kathbath asr #5369

Merged
merged 40 commits into from Aug 16, 2023
Merged

Kathbath asr #5369

merged 40 commits into from Aug 16, 2023

Conversation

bloodraven66
Copy link
Contributor

@bloodraven66 bloodraven66 commented Jul 24, 2023

What?

asr recipe for KathBath corpus - https://ai4bharat.iitm.ac.in/indic-superb

Todo-

  • Train mr model
  • change ffmpeg usage
  • improve results on some languages
  • Upload all models

@mergify mergify bot added the ESPnet2 label Jul 24, 2023
@sw005320 sw005320 requested a review from ftshijt July 24, 2023 16:32
@sw005320 sw005320 added ASR Automatic speech recogntion Recipe labels Jul 24, 2023
@sw005320 sw005320 added this to the v.202307 milestone Jul 24, 2023
egs2/kathbath/asr1/local/data.sh Outdated Show resolved Hide resolved
egs2/kathbath/asr1/local/data.sh Outdated Show resolved Hide resolved
@kan-bayashi kan-bayashi modified the milestones: v.202307, v.202312 Aug 3, 2023
@sw005320 sw005320 marked this pull request as ready for review August 3, 2023 19:35
Copy link
Contributor

@sw005320 sw005320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Can you add a result in README.md with pre-trained model links?
  2. Can you also add the corpus information here? https://github.com/espnet/espnet/blob/master/egs2/README.md

egs2/TEMPLATE/asr1/db.sh Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #5369 (8cb9055) into master (88050b2) will increase coverage by 5.21%.
Report is 13 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5369      +/-   ##
==========================================
+ Coverage   71.97%   77.18%   +5.21%     
==========================================
  Files         679      679              
  Lines       61703    61703              
==========================================
+ Hits        44410    47628    +3218     
+ Misses      17293    14075    -3218     
Flag Coverage Δ
test_configuration_espnet2 ∅ <ø> (∅)
test_integration_espnet1 65.73% <ø> (?)
test_integration_espnet2 48.53% <ø> (-0.02%) ⬇️
test_python_espnet1 20.26% <ø> (ø)
test_python_espnet2 52.08% <ø> (+0.05%) ⬆️
test_utils 23.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 60 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sw005320
Copy link
Contributor

sw005320 commented Aug 3, 2023

@mergify
Copy link
Contributor

mergify bot commented Aug 4, 2023

This pull request is now in conflict :(

@mergify mergify bot added the conflicts label Aug 4, 2023
@bloodraven66
Copy link
Contributor Author

LGTM! Please let us know if you have finished your action items and then we can merge it~ Thanks for your contribution.

Sure, should be able to complete in 2 days, will update

@bloodraven66
Copy link
Contributor Author

LGTM! Please let us know if you have finished your action items and then we can merge it~ Thanks for your contribution.

It is complete

Copy link
Contributor

@sw005320 sw005320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the conflict?
Also, the README.md looks good, but is it possible to make it more similar (consistent) to the other README.md?

egs2/kathbath/asr1/README.md Outdated Show resolved Hide resolved
Co-authored-by: Shinji Watanabe <sw005320@gmail.com>
@bloodraven66
Copy link
Contributor Author

bloodraven66 commented Aug 8, 2023

Can you fix the conflict? Also, the README.md looks good, but is it possible to make it more similar (consistent) to the other README.md?

I did not keep the standard readme since there are 12 languages, 4 test set for each language, 12 * 4 * 2 rows for WER and CER. Is that ok?

@mergify mergify bot removed the conflicts label Aug 8, 2023
@sw005320
Copy link
Contributor

sw005320 commented Aug 8, 2023

Can you fix the conflict? Also, the README.md looks good, but is it possible to make it more similar (consistent) to the other README.md?

I did not keep the standard readme since there are 12 languages, 4 test set for each language, 12 * 4 * 2 rows for WER and CER. Is that ok?

Sure, but how about adding the other information, e.g., method name, environment, etc. like https://github.com/espnet/espnet/blob/master/egs2/librispeech_100/asr1/README.md#e-branchformer

@bloodraven66
Copy link
Contributor Author

Can you fix the conflict? Also, the README.md looks good, but is it possible to make it more similar (consistent) to the other README.md?

I did not keep the standard readme since there are 12 languages, 4 test set for each language, 12 * 4 * 2 rows for WER and CER. Is that ok?

Sure, but how about adding the other information, e.g., method name, environment, etc. like https://github.com/espnet/espnet/blob/master/egs2/librispeech_100/asr1/README.md#e-branchformer

Added

@sw005320
Copy link
Contributor

Thanks a lot, @bloodraven66!

@sw005320 sw005320 added the auto-merge Enable auto-merge label Aug 10, 2023
@mergify mergify bot merged commit 66ccb85 into espnet:master Aug 16, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASR Automatic speech recogntion auto-merge Enable auto-merge ESPnet2 README Recipe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants